Add bottom border to tab toolbar

RESOLVED FIXED in Thunderbird 22.0

Status

Thunderbird
Theme
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: Paenglab, Assigned: Paenglab)

Tracking

unspecified
Thunderbird 22.0
All
Linux
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 2 obsolete attachments)

(Assignee)

Description

4 years ago
When we introduced the Australis tabs on Linux we haven't drawn a bottom border because some Linus themes like Clearlooks draw their own borders. This double borders then would looked weird.

I've found now a solution to use our own border.
(Assignee)

Comment 1

4 years ago
Created attachment 695805 [details] [diff] [review]
proposed fix

My solution is a negative top margin to remove the Linux theme border and add 1px padding to have still the same height.

I've also added new tab graphics to remove the darker part where the tab border and the toolbar border come together.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #695805 - Flags: ui-review?(bugs)
Attachment #695805 - Flags: review?(bugs)
(Assignee)

Comment 2

4 years ago
Created attachment 704589 [details] [diff] [review]
unbitrotted patch
Attachment #695805 - Attachment is obsolete: true
Attachment #695805 - Flags: ui-review?(bugs)
Attachment #695805 - Flags: review?(bugs)
Attachment #704589 - Flags: ui-review?(bugs)
Attachment #704589 - Flags: review?(bugs)
I don't currently have a running build. Could you post a screenshot?
(Assignee)

Comment 4

4 years ago
Created attachment 726226 [details]
comparison

The two on top are Clearlooks-Phenix and Mint-x with actual look.

The two on bottom are the same with patch applied.
Comment on attachment 704589 [details] [diff] [review]
unbitrotted patch

UI and code looks good!
Approved!
Attachment #704589 - Flags: ui-review?(bugs)
Attachment #704589 - Flags: ui-review+
Attachment #704589 - Flags: review?(bugs)
Attachment #704589 - Flags: review+
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/9ff930f2836c
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 22.0
I backed this out due to unit test failures:

https://hg.mozilla.org/comm-central/rev/47d10a58fa47

https://tbpl.mozilla.org/php/getParsedLog.php?id=20879665&tree=Thunderbird-Trunk#error5

TEST-START | /home/cltbld/talos-slave/test/build/mozmill/folder-display/test-opening-messages.js | test_open_message_in_new_window
Step Pass: {"function": "Controller.keypress()"}
Test Failure: messenger window height not equal to the sum of children heights: "stringbundleset": 0, "": 0, "": 0, "": 0, "": 0, "": 0, "": 0, "": 0, "": 0, "": 0, "": 0, "": 0, "": 0, "": 0, "": 0, "": 0, "": 0, "": 0, "mailCommands": 0, "mailKeys": 0, "": 0, "attachmentListContext": 0, "attachmentItemContext": 0, "header-toolbar-context-menu": 0, "attachment-toolbar-context-menu": 0, "copyUrlPopup": 0, "toolbar-context-menu": 0, "navigation-toolbox": 22, "mail-toolbox": 38, "aHTMLTooltip": 0, "messagepaneboxwrapper": 1045, "customizeToolbarSheetPopup": 0, "status-bar": 22, "": 0, "": 0, "": 0, "": 0, "": 0, "": 0, "": 0, "": 0, "": 0, "": 0, "": 0, "": 0, "": 0, "": 0, "": 0, "": 0, "": 0, "": 0, "": 0, "": 0, "": 0, "": 0, "": 0, "": 0, "": 0, "": 0, "": 0, "": 0, "": 0, : '1126' != '1127'.
TEST-UNEXPECTED-FAIL | /home/cltbld/talos-slave/test/build/mozmill/folder-display/test-opening-messages.js | test-opening-messages.js::test_open_message_in_new_window
TEST-START | /home/cltbld/talos-slave/test/build/mozmill/folder-display/test-opening-messages.js | test_open_message_in_existing_window
Step Pass: {"function": "Controller.keypress()"}
Test Failure: Timed out waiting for window open!
TEST-UNEXPECTED-FAIL | /home/cltbld/talos-slave/test/build/mozmill/folder-display/test-opening-messages.js | test-opening-messages.js::test_open_message_in_existing_window
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 8

4 years ago
Created attachment 727914 [details] [diff] [review]
patch passing mozmill test

This patch is passing the test-opening-messages.js::test_open_message_in_new_window test. See https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=3f63d2a74541

The only change is in messageWindow.css the margin-top/padding-top 0px.
Attachment #704589 - Attachment is obsolete: true
Attachment #727914 - Flags: ui-review+
Attachment #727914 - Flags: review?(mconley)
Comment on attachment 727914 [details] [diff] [review]
patch passing mozmill test

Review of attachment 727914 [details] [diff] [review]:
-----------------------------------------------------------------

Code looks good to me. Thanks Paenglab!
Attachment #727914 - Flags: review?(mconley) → review+
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/cc1b1733dae2
Status: REOPENED → RESOLVED
Last Resolved: 4 years ago4 years ago
Flags: in-testsuite+
Keywords: checkin-needed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.