Closed Bug 824800 Opened 7 years ago Closed 7 years ago

Social chat windows should close on middle mouse button, and right click should not minimize

Categories

(Firefox Graveyard :: SocialAPI, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 20

People

(Reporter: jaws, Assigned: markh)

Details

Attachments

(1 file, 1 obsolete file)

Currently, a click with any mouse key will minimize/restore the chat window. Middle clicking should close the chat window (similar to tabs), and right-click should be a no-op.
Assignee: nobody → mhammond
Attachment #696694 - Flags: review?(jaws)
Comment on attachment 696694 [details] [diff] [review]
left click toggles, middle click closes, right click does nothing

>+      <method name="onclick">

This should be named "onTitlebarClick" or something similar.

>+          if (!aEvent)
>+            return;

This isn't expected, right? Why silently accept that mistake rather than letting it fail when accessing aEvent.button?
Comment on attachment 696694 [details] [diff] [review]
left click toggles, middle click closes, right click does nothing

Review of attachment 696694 [details] [diff] [review]:
-----------------------------------------------------------------

I agree with Dao. Thanks for putting a patch in for this, I was planning on doing it but hadn't gotten to it yet :)
Attachment #696694 - Flags: review?(jaws)
Attachment #696694 - Attachment is obsolete: true
Attachment #696897 - Flags: review?(jaws)
Attachment #696897 - Flags: review?(dao)
Attachment #696897 - Flags: review?(dao) → review+
https://hg.mozilla.org/mozilla-central/rev/40025046531f
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 20
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.