824800 - Social chat windows should close on middle mouse button, and right click should not minimize

Status: RESOLVED FIXED

(Firefox Graveyard :: SocialAPI, defect)

Description

[Jared Wein [:jaws] (please needinfo? me)]

Currently, a click with any mouse key will minimize/restore the chat window. Middle clicking should close the chat window (similar to tabs), and right-click should be a no-op.

Comment 1

[Mark Hammond [:markh] [:mhammond]]

Attachment: left click toggles, middle click closes, right click does nothing

Comment 2

[Dão Gottwald [:dao]]

Comment on attachment 696694 [details] [diff] [review]
left click toggles, middle click closes, right click does nothing

>+      <method name="onclick">

This should be named "onTitlebarClick" or something similar.

>+          if (!aEvent)
>+            return;

This isn't expected, right? Why silently accept that mistake rather than letting it fail when accessing aEvent.button?

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 696694 [details] [diff] [review]
left click toggles, middle click closes, right click does nothing

Review of attachment 696694 [details] [diff] [review]:
-----------------------------------------------------------------

I agree with Dao. Thanks for putting a patch in for this, I was planning on doing it but hadn't gotten to it yet :)

Comment 4

[Mark Hammond [:markh] [:mhammond]]

Attachment: Updated based on comments

Comment 5

[Mark Hammond [:markh] [:mhammond]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/40025046531f

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/40025046531f