825004 - [css-text-decor-3] Unprefix CSS3 Text Decoration

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Comment 1

[Jet Villegas (inactive)]

This spec has gone CR. Time to drop the prefix!

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Thank you for the information. When we drop the prefix, we should make text-decoration a shorthand property of text-decoration-*.

Comment 3

[Tooru Fujisawa [:arai]]

Attachment: Unprefix CSS3 Text Decoration.

Unprefixed code, styles, and tests.

Green on try run: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=0bba8c40f422

I'm also preparing a patch for bug 1039488, code is ready, tests are not yet written.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 8521158 [details] [diff] [review]
Unprefix CSS3 Text Decoration.

r=dbaron, although we should probably also add aliases of the prefixed properties for a release or two.

This should land at the same time as the aliases and the text-decoration-as-shorthand patch.

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8521158 [details] [diff] [review]
Unprefix CSS3 Text Decoration.

Thank you for your work!

>diff --git a/layout/style/test/test_transitions_per_property.html b/layout/style/test/test_transitions_per_property.html
>--- a/layout/style/test/test_transitions_per_property.html
>+++ b/layout/style/test/test_transitions_per_property.html
>@@ -77,18 +77,18 @@ var supported_properties = {
>                                 test_length_clamped ],
>     "-moz-column-width": [ test_length_transition,
>                            test_length_clamped ],
>     "-moz-image-region": [ test_rect_transition ],
>     "-moz-outline-radius-bottomleft": [ test_radius_transition ],
>     "-moz-outline-radius-bottomright": [ test_radius_transition ],
>     "-moz-outline-radius-topleft": [ test_radius_transition ],
>     "-moz-outline-radius-topright": [ test_radius_transition ],
>-    "-moz-text-decoration-color": [ test_color_transition,
>-                                    test_border_color_transition ],
>+    "text-decoration-color": [ test_color_transition,
>+                               test_border_color_transition ],
>     "background-color": [ test_color_transition ],
>     "background-position": [ test_background_position_transition,
>                              // FIXME: We don't currently test clamping,
>                              // since background-position uses calc() as
>                              // an intermediate form.
>                              /* test_length_percent_pair_unclamped */ ],
>     "background-size": [ test_background_size_transition,
>                          // FIXME: We don't currently test clamping,

Isn't this list is ordered from a to z? If so, you should move the lines below. Anyway, thanks!

Comment 6

[Tooru Fujisawa [:arai]]

Attachment: Part 1: Unprefix CSS3 Text Decoration. r=dbaron

Thank you for reviewing!

(In reply to David Baron [:dbaron] (UTC-8) (needinfo? for questions) from comment #4)
> Comment on attachment 8521158 [details] [diff] [review]
> Unprefix CSS3 Text Decoration.
> 
> r=dbaron, although we should probably also add aliases of the prefixed
> properties for a release or two.

I'll post Part 2 for aliases soon.

(In reply to Masayuki Nakano (:masayuki) (Mozilla Japan) from comment #5)
> Isn't this list is ordered from a to z? If so, you should move the lines
> below. Anyway, thanks!

Yeah, seems that way, fixed.

Comment 7

[Tooru Fujisawa [:arai]]

Attachment: Part 2: Provide temporary aliases for '-moz-text-decoration-*'.

Added aliases.

Green on try run: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=6bfb27e1ac5d

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 8521455 [details] [diff] [review]
Part 2: Provide temporary aliases for '-moz-text-decoration-*'.

r=dbaron

Could you also file a separate bug on backing this out in a few releases?

Comment 9

[Tooru Fujisawa [:arai]]

Thanks again!

(In reply to David Baron [:dbaron] (UTC-8) (needinfo? for questions) from comment #8)
> Could you also file a separate bug on backing this out in a few releases?

Filed as bug 1097922.


I'll post a patch for bug 1039488 in a few days.

Comment 10

[Tooru Fujisawa [:arai]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ecc30ea0f2c1
https://hg.mozilla.org/integration/mozilla-inbound/rev/6d55e2ca5c39

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ecc30ea0f2c1
https://hg.mozilla.org/mozilla-central/rev/6d55e2ca5c39

Comment 12

[Tooru Fujisawa [:arai]]

Updated following documents:
  https://developer.mozilla.org/en-US/docs/Web/CSS/text-decoration-color
  https://developer.mozilla.org/en-US/docs/Web/CSS/text-decoration-line
  https://developer.mozilla.org/en-US/docs/Web/CSS/text-decoration-style
  https://developer.mozilla.org/en-US/Firefox/Releases/36

Site Compatibility page will be updated after Firefox 36 Aurora is released.

Comment 13

[Jean-Yves Perrier [:teoli]]

Thanks :arai! Much appreciated. Made minor fixes to the pages.