825197 - When passing +/-Infinity to .valueAsNumber, TypeError should be thrown

Status: RESOLVED FIXED

(Core :: DOM: Forms, defect, P5)

Description

[Mounir Lamouri (:mounir)]

Bug 825009 implements throwing but not TypeError because that is only available with WebIDL. We should make sure to throw TypeError when bug 825196 is resolved.

Comment 1

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1472046

Move all DOM bugs that haven’t been updated in more than 3 years and has no one currently assigned to P5.

If you have questions, please contact :mdaly.

Comment 2

[Sajid Anwar [:sajidanwar]]

Hi all, I'd like to take this bug. I've got this mostly complete, just finalizing adding two new WPT files (one for valueAsNumber, and a very similar one for valueAsDate — these are the only two instances of TypeError in the HTML Input specification). I'll probably publish a patch tomorrow.

Comment 3

[Sajid Anwar [:sajidanwar]]

Attachment: Bug 825197 - Throw TypeError when providing infinite number to HTMLInputElement.valueAsNumber. r=avandolder

Also added two new Web Platform Tests to validate TypeError from valueAsNumber and valueAsDate, which are the
only two TypeError conditions in the HTML Input specification: https://html.spec.whatwg.org/multipage/input.html

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/7b80b1b2b71e
https://hg.mozilla.org/integration/autoland/rev/19d18586c082
Throw TypeError when providing infinite number to HTMLInputElement.valueAsNumber. r=avandolder

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/19d18586c082

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/53100 for changes under testing/web-platform/tests

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 8

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Thank you Sajid Anwar for the great work here!