825009 - Handles NaN and Infinity passed to .valueAsNumber

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Mounir Lamouri (:mounir)]

Attachment: Patch

.valueAsNumber = NaN should set the value to ""
.valueAsNumber = +/-Infinity should throw a TypeError. For the moment we can't throw that so we are just throwing another error.

Comment 1

[Mounir Lamouri (:mounir)]

W3C bug regarding the change: https://www.w3.org/Bugs/Public/show_bug.cgi?id=20496

Comment 2

[Robert Longson [:longsonr]]

Did you consider using NS_ENSURE_FINITE from nsContentUtils.h?

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 696069 [details] [diff] [review]
Patch

Since rest of the form element code uses MOZ_DOUBLE_* better to use it here too.
However, we need to make DOM code to use only one style of NAN macros.
A followup bug would be good.

// "" is being converted to 0.
s/being//

Add a todo for TypeError.

Comment 4

[Mounir Lamouri (:mounir)]

(In reply to Olli Pettay [:smaug] from comment #3)
> Comment on attachment 696069 [details] [diff] [review]
> Patch
> 
> Since rest of the form element code uses MOZ_DOUBLE_* better to use it here
> too.
> However, we need to make DOM code to use only one style of NAN macros.
> A followup bug would be good.

bug 825200

> Add a todo for TypeError.

There is a todo but that wasn't pointing to a bug. There is now bug 825197.

Comment 5

[Mounir Lamouri (:mounir)]

https://hg.mozilla.org/mozilla-central/rev/0bb4773db082

Comment 6

[Florian Scholz (Open Web Docs)]

See bug 866440 for documentation.