825342 - browser_480893.js | uncaught exception - SyntaxError: missing ( after for at chrome://communicator/content/aboutSessionRestore.js:59

Status: RESOLVED FIXED

(SeaMonkey :: Session Restore, defect)

Description

[Frank Wein [:mcsmurf]]

This test http://mxr.mozilla.org/comm-central/source/suite/common/tests/browser/browser_480893.js uses sessionrestore, currently sessionrestore throws a JS error:
NEXT ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/suite/common/tests/browser/browser_480893.js | uncaught exception - SyntaxError: missing ( after for at chrome://communicator/content/aboutSessionRestore.js:59
Stack trace:
    JS frame :: chrome://mochikit/content/tests/SimpleTest/SimpleTest.js :: simpletestOnerror :: line 1067
    native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0

This is due to Bug 804834 which disabled for each for content JavaScript when using the default JS version in content. Two possible solutions for this:
1. Explicitly use JS 1.8:
<script type="application/javascript;version=1.8"

Bug 824289 aims to completely remove for each from content JS though, no matter what JS version is used.
2. Replace for each with for ( ... of ...)

Comment 1

[Frank Wein [:mcsmurf]]

Attachment: Patch

Comment 2

[Frank Wein [:mcsmurf]]

Attachment: Patch

This patch replaced for each in that file with for (... of ...). ".tabs" is an array, so the results of using for...of should be the same.

Comment 3

[Frank Wein [:mcsmurf]]

Pushed: https://hg.mozilla.org/comm-central/rev/78fc9697449e