82544 - First and last quotes in value fields are being ignored

Status: VERIFIED FIXED

(Core :: DOM: HTML Parser, defect)

Description

[a.c.r.martin]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux 2.2.14-5.0 i686; en-US; rv:0.9)
Gecko/20010505
BuildID:    2001050521

If a <form> has a <select> containing <option>s of the form:
<option value="'somevalue'">
then the single inverted commas are not sent using the GET method. This works
fine under Netscape 4.xx and MIE


Reproducible: Always
Steps to Reproduce:
1. Goto 
http://www.rubic.rdg.ac.uk/cgi-bin/AndrewMartin/xslt.pl?src=antibodies.xml&xsl=summary.xsl
2. Choose an item from the 'Sort By' pull-down select
3. Click 'sort'
4. Examine the resulting URL

Actual Results:  The resulting URL from the GET-method form looks like:
http://www.rubic.rdg.ac.uk/cgi-bin/AndrewMartin/xslt.pl?src=antibodies.xml&xsl=summary.xsl&params=%24sortkey%3Dpdb

 (where %24 is the code for $ and %3D is the code for =)

Expected Results: 
http://www.rubic.rdg.ac.uk/cgi-bin/AndrewMartin/xslt.pl?src=antibodies.xml&xsl=summary.xsl&params=%27%24sortkey%3Dpdb%27

 (where %24 is the code for $  %3D is the code for =  and %27 is the code for ')

Comment 1

[rods (gone)]

reassigning

Comment 2

[Vladimir Ermakov]

This is a parser bug. It reads value="'foo'" as value=foo
but if you have a single quote like "'foo" is read as 'foo

It only happens if the single and double quotes are adjacent. 
Neither Netscape 4 nor IE have this behaviour.

Comment 3

[Vladimir Ermakov]

Attachment: testcase

Comment 4

[Vladimir Ermakov]

*** Bug 82564 has been marked as a duplicate of this bug. ***

Comment 5

[Vladimir Ermakov]

changing summary, adding keywords from duplicate

Comment 6

[Eric Pollmann]

Over to the parser guru...  (Thanks Harish!)

Comment 7

[harishd]

This is trivial to fix. 

Comment 8

[harishd]

Attachment: patch v1.1

Comment 9

[vidur (gone)]

Hallelujah! The parser's finally doing its job and stripping the quotes out.
This was a point of contention prior to Mozilla 0.6.
r/sr=vidur.

Comment 10

[a.c.r.martin]

[e-mail] said:
>Hallelujah! The parser's finally doing its job and stripping the quotes out.

Surely that cannot be the right behaviour. If my HTML says
<option value="'somevalue'"> then surely it is obvious that the single inverted
commas must be part of what is assigned to 'value' !

As stated in the duplicate bug post (82564), this is data loss.

Comment 11

[Daniel Bratell]

[e-mail]: I think he meant that the parser strips the outer quotes 
so that the content sink doesn't have to do it any more.

There is a performance patch/rewrite of this function in bug 83945 which copies 
the old behaviour which apparently isn't correct. So the right thing is:

|   foo  | -> |foo|
|   '    foo ' | -> |'    foo '|
?

I'm marking that bug as dependent of this and will rework it when this is in.

Comment 12

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Amen... I mean r=heikki

Comment 13

[Boris Zbarsky [:bzbarsky]]

*** Bug 85805 has been marked as a duplicate of this bug. ***

Comment 14

[Asa Dotzler [:asa]]

a= [e-mail] for checkin to the trunk.
(on behalf of drivers)

Comment 15

[harishd]

Fix is in.

Comment 16

[harishd]

Fixed

Comment 17

[Vladimir Ermakov]

Verifying fixed on windows 98 build 2001-06-21-04-trunk and
build 2001-06-20-21-trunk linux redhat

Comment 18

[Boris Zbarsky [:bzbarsky]]

*** Bug 87329 has been marked as a duplicate of this bug. ***