Closed Bug 825449 Opened 11 years ago Closed 11 years ago

Filter editor: Accesskey for 'Perform these actions' should set/move focus to first action item (at the moment invisible/not shown)

Categories

(MailNews Core :: Filters, enhancement)

Product:
MailNews Core
Component:
Filters
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 22.0

People

(Reporter: aryx, Assigned: aceman)

References

Details

Attachments

(1 file, 1 obsolete file)

patch v2
4.36 KB, patch
rkent
: review+
bwinton
: ui-review+
Details | Diff | Splinter Review 
Thunderbird Earlybird 19.0a2 20121229

At the moment, the filter editor for creating/editing a filter has the box 'Perform these actions' with access key 'P'. Pressing this access key will move it to the label, there is no focus shown and nothing can be done there, so it should be set to the first action item in that box.
Assignee: nobody → acelists
You mean focus the first action menulist?
Yes (at least something with a focus ring indicator).
Attached patch patch (obsolete) — — Splinter Review 
Ok, here you go.
Attachment #698342 - Flags: ui-review?(bwinton)
Attachment #698342 - Flags: feedback?(archaeopteryx)
Status: NEW → ASSIGNED
OS: Windows XP → All
Product: Thunderbird → MailNews Core
Hardware: x86 → All
Comment on attachment 698342 [details] [diff] [review]
patch

Thank you, your fix works like I imagined.
Attachment #698342 - Flags: feedback?(archaeopteryx) → feedback+
Comment on attachment 698342 [details] [diff] [review]
patch

Okay so ui-r=me if (and this is a big if!), when you've selected item 3, and focus another element, and then re-focus the list, item 3 is still the focused one.  (Does that make sense?  I can't seem to compile, so I'm sort of going by inspection here…)

Thanks,
Blake.
Attachment #698342 - Flags: ui-review?(bwinton) → ui-review+
Attached patch patch v2 — — Splinter Review 
Ok, if you think so.
Attachment #698342 - Attachment is obsolete: true
Attachment #715232 - Flags: ui-review?(bwinton)
Attachment #715232 - Flags: review?(kent)
Comment on attachment 715232 [details] [diff] [review]
patch v2

Looks fine to me. Thanks for the patch!
Attachment #715232 - Flags: review?(kent) → review+
Comment on attachment 715232 [details] [diff] [review]
patch v2

Seems good.  ui-r=me.
Attachment #715232 - Flags: ui-review?(bwinton) → ui-review+
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/525b199453d9
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 22.0
Depends on: 1024908
You need to log in before you can comment on or make changes to this bug.