Closed
Bug 825605
Opened 12 years ago
Closed 11 years ago
Element.setAttribute(attr, null); now sets the attribute to the string "null" instead of the empty string
Categories
(SeaMonkey :: MailNews: General, defect)
SeaMonkey
MailNews: General
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.18
People
(Reporter: neil, Assigned: neil)
References
Details
Attachments
(1 file)
|
1.59 KB,
patch
|
mnyromyr
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #819798 +++ I've found a case where it turns out we explicitly set an attribute to null. It doesn't really matter as long as it's any value other than "true", but I thought we should change it for consistency.
|
Assignee | |
Comment 1•12 years ago
|
||
The other hunk is a drive-by strict JS warning. I didn't see any point in messing around with ?: when we don't care what the non-true value is, so we might as well stringify the boolean.
|
||
Comment 2•11 years ago
|
||
Comment on attachment 696724 [details] [diff] [review] Possible patch (by inspection)
Attachment #696724 -
Flags: review?(mnyromyr) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
Pushed comm-central changeset 3646814ab76d.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
||
Updated•11 years ago
|
Target Milestone: --- → seamonkey2.18
You need to log in
before you can comment on or make changes to this bug.
Description
•