Closed Bug 825647 Opened 7 years ago Closed 7 years ago

nsUrlClassifierStreamUpdater.cpp:24:0: warning: "LOG" redefined [enabled by default]

Categories

(Toolkit :: Safe Browsing, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 20

People

(Reporter: dholbert, Assigned: dholbert)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Build warning:
{
/mozilla/toolkit/components/url-classifier/nsUrlClassifierStreamUpdater.cpp:24:0: warning: "LOG" redefined [enabled by default]

In file included from ../../../dist/include/nsIUrlClassifierDBService.h:17:0,
                 from /mozilla/toolkit/components/url-classifier/nsUrlClassifierStreamUpdater.cpp:12:

/mozilla/toolkit/components/url-classifier/Entries.h:17:0: note: this is the location of the previous definition
}

I think the chunk in Entries.h doesn't belong there. It looks like this was added in this cset:
https://hg.mozilla.org/mozilla-central/diff/90f47a584aed/toolkit/components/url-classifier/Entries.h#l1.53
...without being used/needed anywhere.

If I remove that chunk, it fixes the build warning without causing any problems.
Attached patch fixSplinter Review
Attachment #696772 - Flags: review?(gpascutto)
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Attachment #696772 - Flags: review?(gpascutto) → review+
Blocks: 825941
https://hg.mozilla.org/mozilla-central/rev/6a6d4719683f
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 20
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.