825941 - Mark toolkit/components/url-classifier as warning-free

Status: RESOLVED FIXED

(Toolkit :: Safe Browsing, defect)

Description

[Daniel Holbert [:dholbert]]

Now that the patches in bug 825647 and bug 825627 have landed, toolkit/components/url-classifier is build-warning-free.

Filing this bug on marking it as such, to have our build system enforce that. (for configurations with --enable-warnings-as-errors)

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix

Green Try push (on non-windows platforms), from a few days ago:
  https://tbpl.mozilla.org/?tree=Try&rev=2caa089f0e0c

(I'll do a windows try push before landing, too, since we *just* started honoring this on Windows, too, as of bug 824247's landings this morning.)

Comment 2

[Daniel Holbert [:dholbert]]

Windows try push failed:
  https://tbpl.mozilla.org/?tree=Try&rev=701fce62be3a
...because there's a windows-only warning -- I filed bug 826052 on that, w/ a patch.

With bug 826052 fixed, this builds successfully on windows:
  https://tbpl.mozilla.org/?tree=Try&rev=890f76852489

Comment 3

[Gregory Szorc [:gps]]

Comment on attachment 697048 [details] [diff] [review]
fix

Review of attachment 697048 [details] [diff] [review]:
-----------------------------------------------------------------

Rubber stamp.

Comment 4

[Daniel Holbert [:dholbert]]

Thanks! (oops, intended to review-ping gcp on IRC, accidentally pinged gps instead; but as a build guy he's qualified to review it as well, so it worked out. :))

Comment 5

[Daniel Holbert [:dholbert]]

I did one more try push before landing:
 https://tbpl.mozilla.org/?tree=Try&rev=7b34974603bf
and uncovered an set-but-unused variable in opt Android builds. (Apparently we're using a newer version of GCC in Android vs. Desktop, because I'm pretty sure our TBPL desktop builders don't warn about that.)

So I pushed a trivial helper-patch to mark the variable in question as DebugOnly:
  https://hg.mozilla.org/integration/mozilla-inbound/rev/e742cc9b67d3
and landed this bug's patch:
  https://hg.mozilla.org/integration/mozilla-inbound/rev/36467bcc46ad

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/e742cc9b67d3
https://hg.mozilla.org/mozilla-central/rev/36467bcc46ad