825750 - Right pane of Preferences dialog empty when opened from "Edit → SeaMonkey preferences" in ChatZilla

Status: RESOLVED FIXED

(Other Applications :: ChatZilla, defect)

Description

[Tony Mechelynck [:tonymec]]

Mozilla/5.0 (X11; Linux x86_64; rv:20.0) Gecko/20100101 Firefox/20.0 SeaMonkey/2.17a1 ID:20130101003010 c-c:cf44b65f2bf6 m-c:dec6aa71da64

Reproducible: Always

Steps to Reproduce:
1. Make sure ChatZilla is running (as a SeaMonkey extension).
2. In ChatZilla, click "Edit → SeaMonkey Preferences…"

Actual results:
Preferences dialog opens with an empty "Appearance" pane showing.

Expected results:
"Appearance" pane should display the checkboxes for which windows to open at startup, the "show toolbars as" radio buttons, the "Show Tooltips" checkbox, and the UI language rolldown.

Additional info:
Switching away and back in the left pane of the dialog displays the right pane correctly.

Comment 1

[Philip Chee]

> function cmdDoCommand(e)
> {
>     if (e.cmdName == "cmd_mozillaPrefs")
>     {
>         // open Mozilla/SeaMonkey preferences
>         const PREF_URL = 'chrome://chatzilla/content/pref-irc.xul';
>         if (goPreferences.arity == 1) // SeaMonkey 2.x
>             goPreferences('navigator_pane');
>         else // Mozilla, SeaMonkey 1.x, etc.
>             goPreferences('navigator', PREF_URL, 'navigator');
>     }

User agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:20.0) Gecko/20100101 Firefox/20.0 SeaMonkey/2.17a1
Build identifier: 20130101135623
"arity" in goPreferences => false.

Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.1.20pre) Gecko/20110606 Lightning/1.0b2pre SeaMonkey/2.0.15pre
"arity" in goPreferences => true.

<https://developer.mozilla.org/en-US/docs/JavaScript/Reference/Global_Objects/Function/arity>
Obsolete since JavaScript 1.8.6
The arity property no longer exists and has been replaced by the Function.prototype.length property.


goPreferences.length => 1
<https://developer.mozilla.org/en-US/docs/JavaScript/Reference/Global_Objects/Function/length>
Specifies the number of arguments expected by the function.

Implemented in  	JavaScript 1.1
ECMAScript Edition 	ECMAScript 1st Edition

Conclusion: use goPreferences.length instead of goPreferences.arity

Comment 2

[Tony Mechelynck [:tonymec]]

Attachment: patch v0

Comment 3

[Tony Mechelynck [:tonymec]]

Comment on attachment 696887 [details] [diff] [review]
patch v0

adding additional review requests since many people seem to be on holiday

Comment 4

[Tony Mechelynck [:tonymec]]

Comment on attachment 696887 [details] [diff] [review]
patch v0

Oops, reviewer must be owner or peer. But I still don't know for sure who is on holiday and who isn't.

Comment 5

[James Ross]

Comment on attachment 696887 [details] [diff] [review]
patch v0

This review has been flown in specially from Tokyo, sorry for the delay.

Comment 6

[Tony Mechelynck [:tonymec]]

Thanks Silver :-)

N.B. In case the checkin-needed keyword is acted upon by someone who doesn't usually do ChatZilla: the ChatZilla repository is at http://hg.mozilla.org/chatzilla/

Comment 7

[Tony Mechelynck [:tonymec]]

P.S. This patch is of course for the "default" branch (which at the moment does not include the repository tip).

Comment 8

[Tony Mechelynck [:tonymec]]

http://hg.mozilla.org/chatzilla/rev/9cd282dbf5c2

Comment 9

[Tony Mechelynck [:tonymec]]

Mozilla/5.0 (X11; Linux x86_64; rv:20.0) Gecko/20100101 Firefox/20.0 SeaMonkey/2.17a1 ID:20130106215151 c-c:a976311210e4 m-c:fed4e5f66b3d

The new cZ build is found at http://james-ross.co.uk/mozilla/chatzilla/nightly/builds/0.9.89/2013011022/chatzilla-0.9.89-2013011022.xpi -- I installed it into this version of SeaMonkey and "Edit → SeaMonkey Preferences" opens the Preferences dialog correctly filled at the same pane as when using "Edit → Preferences" in the Browser.

If this XPI doesn't (after restart) solve the problem for you, please REOPEN with specifics, otherwise after a "reasonable" time this bug will be regarded as VERIFIED.

Comment 10

[Tony Mechelynck [:tonymec]]

Hm, the question of "what is fixed where" is more ticklish than I thought:
- SeaMonkey trunk builds always pack the latest Chatzilla default branch changeset; this means that present builds of SeaMonkey 2.18a1, built on the same "core" code as Firefox 21.0a1, pack the fixed version of ChatZilla.
- However, SeaMonkey Aurora builds pack the latest ChatZilla release by means of a tag (presently CHATZILLA_0_9_89_RELEASE), so if nothing is done, in six weeks' time SeaMonkey 2.18a2 will "lose" the fix compared to 2.18a1.
- In all cases, the cZ version packaged with a given Sm build is installed at {appdir}/distribution/extensions/{59c81df5-4b7a-477b-912d-4e0fdf64e5f2}.xpi (where {appdir} means the application directory, for instance on Linux typically /usr/local/seamonkey),and will be installed into the profile the next time an application version change is detected at startup, provided that the "new" cZ version is higher than that of any cZ already present in that profile.

Conclusion: present SeaMonkey 2.17a2 builds (with the cZ build packaged with them), and any lower versions where the "arity" function is not defined in Javascript, are still "affected". Present 2.18a1 builds (with the cZ build packaged with them) are temporarily "fixed" but unless someone does something, they will "lose" the fix when they advance to 2.18a2 Aurora in six weeks or so.

Comment 11

[:Gijs (out for now; he/him)]

(In reply to Tony Mechelynck [:tonymec] from comment #8)
> http://hg.mozilla.org/chatzilla/rev/9cd282dbf5c2

Yeah, sorry for not closing this myself, I was in a train and lost connectivity. Thanks for taking care of it!

(In reply to Tony Mechelynck [:tonymec] from comment #10)
> Hm, the question of "what is fixed where" is more ticklish than I thought:
> - SeaMonkey trunk builds always pack the latest Chatzilla default branch
> changeset; this means that present builds of SeaMonkey 2.18a1, built on the
> same "core" code as Firefox 21.0a1, pack the fixed version of ChatZilla.
> - However, SeaMonkey Aurora builds pack the latest ChatZilla release by
> means of a tag (presently CHATZILLA_0_9_89_RELEASE), so if nothing is done,
> in six weeks' time SeaMonkey 2.18a2 will "lose" the fix compared to 2.18a1.
> - In all cases, the cZ version packaged with a given Sm build is installed
> at
> {appdir}/distribution/extensions/{59c81df5-4b7a-477b-912d-4e0fdf64e5f2}.xpi
> (where {appdir} means the application directory, for instance on Linux
> typically /usr/local/seamonkey),and will be installed into the profile the
> next time an application version change is detected at startup, provided
> that the "new" cZ version is higher than that of any cZ already present in
> that profile.
> 
> Conclusion: present SeaMonkey 2.17a2 builds (with the cZ build packaged with
> them), and any lower versions where the "arity" function is not defined in
> Javascript, are still "affected". Present 2.18a1 builds (with the cZ build
> packaged with them) are temporarily "fixed" but unless someone does
> something, they will "lose" the fix when they advance to 2.18a2 Aurora in
> six weeks or so.

Right, so, moving the tag is probably not the right solution, which means that if we think this is important enough we should make another release, tag it, and ask for approval from the SM folks to ship it with Aurora/Beta/whatever instead of what's currently being shipped. I'm not sure this is important enough for that. James, what do you think?

Comment 12

[Tony Mechelynck [:tonymec]]

(In reply to Gijs Kruitbosch from comment #11)
> (In reply to Tony Mechelynck [:tonymec] from comment #8)
> > http://hg.mozilla.org/chatzilla/rev/9cd282dbf5c2
> 
> Yeah, sorry for not closing this myself, I was in a train and lost
> connectivity. Thanks for taking care of it!

No prob. I happened to notice the push had happened and happily mentioned it here. I almost said "thanks to whoever it was who pushed the change", now I know it was you. :-)

[...]
> Right, so, moving the tag is probably not the right solution, which means
> that if we think this is important enough we should make another release,
> tag it, and ask for approval from the SM folks to ship it with
> Aurora/Beta/whatever instead of what's currently being shipped. I'm not sure
> this is important enough for that. James, what do you think?

The question of how to designate which builds of ChatZilla, Venkman, etc. should be packaged with which builds of SeaMonkey is a recurrent problem which is mentioned every other Tuesday at the fortnightly SeaMonkey status meeting. The only consensus so far is that no satisfactory permanent solution has yet been reached.

Comment 13

[James Ross]

We're going to have to do a release when we sort out bug 829597 and that bug needs fixing ASAP, so this will just come along for the release-tag ride at that point.