825855 - [SeaMonkey] TEST-UNEXPECTED-FAIL | test_browserGlue_migrate.js | example == migrated - See following stack:

Status: NEW

(SeaMonkey :: Startup & Profiles, defect)

Description

[Frank Wein [:mcsmurf]]

Currently the suite\common\places\tests\unit\test_browserGlue_migrate.js test fails:
[...]


TEST-PASS | e:/builds/slave/test/build/xpcshell/tests/suite/common/places/tests/unit/test_browserGlue_migrate.js | [bookmarksObserver.onEndUpdateBatch : 26] 8 != -1

TEST-UNEXPECTED-FAIL | e:/builds/slave/test/build/xpcshell/tests/suite/common/places/tests/unit/test_browserGlue_migrate.js | example == migrated - See following stack:
JS frame :: e:\builds\slave\test\build\xpcshell\head.js :: do_throw :: line 461
JS frame :: e:\builds\slave\test\build\xpcshell\head.js :: _do_check_eq :: line 555
JS frame :: e:\builds\slave\test\build\xpcshell\head.js :: do_check_eq :: line 576
JS frame :: e:/builds/slave/test/build/xpcshell/tests/suite/common/places/tests/unit/test_browserGlue_migrate.js :: continue_test :: line 81
JS frame :: e:/builds/slave/test/build/xpcshell/tests/suite/common/places/tests/unit/test_browserGlue_migrate.js :: bookmarksObserver.onEndUpdateBatch :: line 28
JS frame :: resource://gre/components/nsSuiteGlue.js :: BG_ensurePlacesDefaultQueriesInitialized :: line 1067
JS frame :: resource://gre/modules/commonjs/promise/core.js :: effort :: line 53
JS frame :: resource://gre/modules/commonjs/promise/core.js :: resolveDeferred :: line 125
JS frame :: resource://gre/modules/commonjs/promise/core.js :: then :: line 34
JS frame :: resource://gre/modules/commonjs/promise/core.js :: resolve :: line 167
JS frame :: resource://gre/modules/commonjs/promise/core.js :: resolveDeferred :: line 125
JS frame :: resource://gre/modules/commonjs/promise/core.js :: then :: line 34
JS frame :: resource://gre/modules/commonjs/promise/core.js :: resolve :: line 167
JS frame :: resource://gre/modules/BookmarkHTMLUtils.jsm :: onload :: line 856
native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0

TEST-INFO | (xpcshell/head.js) | exiting test

It looks like nsSuiteGlue.js overwrites migrated bookmarks when a bookmarks.html file is present in profile for import. This should not happen.

Comment 1

[Philip Chee]

Possible fallout from:
Bug 779716 - All bookmarks are deleted and are reset to default bookmarks if bookmarks-*.json are deleted.

Comment 2

[Frank Wein [:mcsmurf]]

I looked at the patch from Bug 779716, I think something is wrong there indeed. It introduced the boolean variable migrationImportsDefaultBookmarks (default value: false), but never changes its value (in contrast to browser glue from Firefox).

Comment 3

[Philip Chee]

The patch from Bug 779716 caused this.
I think the first patch was correct (but incomplete) but was r- in favour of the second patch.

The second patch only ported a small part of Bug 748569 so we should totally backout the patch that landed in bug 779716

Comment 4

[Ed Morley [:emorley]]

Removing keyword, since it's intended for test failures that are seen on Treeherder (and otherwise you'll end up with bugs being marked as worksforme if no occurrences are seen on Treeherder).