825987 - Regression: Save As PDF renders JPEGs as black rectangles

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[nsaedgar]

Attachment: miklowei.pdf

User Agent: Mozilla/5.0 (Windows NT 5.1; rv:17.0) Gecko/20100101 Firefox/17.0
Build ID: 20121128204232

Steps to reproduce:

saved a pdf


Actual results:

Save As PDF renders JPEGs as black rectangles


Expected results:

save as jpg

Comment 1

[Aaron Train [:aaronmt]]

Which version of Firefox on Android are you running? The latest version on Google Play? This was fixed over a year ago for XUL Fennec in bug 704185 (this would be a dupe of bug 758893).

Comment 2

[nsaedgar]

(In reply to Aaron Train [:aaronmt] from comment #1)
> Which version of Firefox on Android are you running? The latest version on
> Google Play? This was fixed over a year ago for XUL Fennec in bug 704185
> (this would be a dupe of bug 758893).

latest from GP ~ v18

Comment 3

[Aaron Train [:aaronmt]]

Which phone, version of Android and website do you get this with?

Comment 4

[nsaedgar]

<http://www.bridgesmathart.org/art-exhibits/bridges06/miklowei.html>

Samsung Galaxy Tab 7.0

Android 3.2

Comment 5

[Aaron Train [:aaronmt]]

This works for me fine on my Galaxy Note II/Galaxy Nexus (Android 4.2)

Honeycomb issue? Anyone able to reproduce?

Comment 6

[nsaedgar]

I add that I get the black rectangle only with some sites, e.g. the bridgesmarthart site indicated.

Comment 7

[Aaron Train [:aaronmt]]

Hey :xti, are you able to reproduce?

Comment 8

[Cristian Nicolae (:xti)]

(In reply to Aaron Train [:aaronmt] from comment #7)
> Hey :xti, are you able to reproduce?

No, I cannot reproduce it on the latest Nightly either, but it occurs on Firefox 18 RC 1.

--
Firefox 20.0a1 (2013-01-07)
Device: Galaxy Tab2 10.1
OS: Android 3.1

Comment 9

[Aaron Train [:aaronmt]]

It would be nice to know what fixed this. Does that mean it's a Honeycomb only issue, xti?

Comment 10

[Cristian Nicolae (:xti)]

(In reply to Aaron Train [:aaronmt] from comment #9)
> It would be nice to know what fixed this. Does that mean it's a Honeycomb
> only issue, xti?

It looks like to be specific to Honeycomb only. I cannot reproduce this issue on ICS/JB. Since the tinderbox inbound builds for this issue/fix are not longer on the server, should I still try to find the window for the good patch?

Comment 11

[Aaron Train [:aaronmt]]

(In reply to Cristian Nicolae (:xti) from comment #10)
> (In reply to Aaron Train [:aaronmt] from comment #9)
> > It would be nice to know what fixed this. Does that mean it's a Honeycomb
> > only issue, xti?
> 
> It looks like to be specific to Honeycomb only. I cannot reproduce this
> issue on ICS/JB. Since the tinderbox inbound builds for this issue/fix are
> not longer on the server, should I still try to find the window for the good
> patch?

trunk-nightly builds would help at least I think

Comment 12

[Aaron Train [:aaronmt]]

I see this when saving a PDF of the front-page of http://www.neowin.net -- reproducible on trunk (mozilla-21)

Comment 13

[Aaron Train [:aaronmt]]

Another URL;

Comment 14

[Aaron Train [:aaronmt]]

mozilla-18 affected; bug 691061?

CC Anthony? Jeff?

Comment 15

[Jeff Muizelaar [:jrmuizel]]

That seems likely.

Comment 16

[Mark Finkle (:mfinkle) (use needinfo?)]

Can we get a backout of bug 691061 ready for a possible 18.0.1?

Comment 17

[nsaedgar]

v. 19 cures the problem with <http://www.bridgesmathart.org/art-exhibits/bridges06/miklowei.html>.
However, <http://www.bridgesmathart.org/art-exhibits/bridges2009/bulatov.html> is still has black rectangles.

Comment 18

[nsaedgar]

v. 19 cures the problem with <http://www.bridgesmathart.org/art-exhibits/bridges06/miklowei.html>.
However, <http://www.bridgesmathart.org/art-exhibits/bridges2009/bulatov.html> still has black rectangles.

Comment 19

[bhavana bajaj [:bajaj]]

(In reply to Mark Finkle (:mfinkle) from comment #16)
> Can we get a backout of bug 691061 ready for a possible 18.0.1?

Mark, this seems to be impacting only honeycomb users, & considering we do not have strong drivers for mobile 18.0.1, this will have to wait till FX 19.
Please let us know if you think this a very serious user facing issue & could be a driver itself else we will wontfix it for Fx18. Thanks.

Comment 20

[Aaron Train [:aaronmt]]

(In reply to bhavana bajaj [:bajaj] from comment #19)
> (In reply to Mark Finkle (:mfinkle) from comment #16)
> > Can we get a backout of bug 691061 ready for a possible 18.0.1?
> 
> Mark, this seems to be impacting only honeycomb users, & considering we do
> not have strong drivers for mobile 18.0.1, this will have to wait till FX 19.
> Please let us know if you think this a very serious user facing issue &
> could be a driver itself else we will wontfix it for Fx18. Thanks.

Sorry, I forgot to mention that I can reproduce on all platforms.

Comment 21

[bhavana bajaj [:bajaj]]

(In reply to Aaron Train [:aaronmt] from comment #20)
> (In reply to bhavana bajaj [:bajaj] from comment #19)
> > (In reply to Mark Finkle (:mfinkle) from comment #16)
> > > Can we get a backout of bug 691061 ready for a possible 18.0.1?
> > 
> > Mark, this seems to be impacting only honeycomb users, & considering we do
> > not have strong drivers for mobile 18.0.1, this will have to wait till FX 19.
> > Please let us know if you think this a very serious user facing issue &
> > could be a driver itself else we will wontfix it for Fx18. Thanks.
> 
> Sorry, I forgot to mention that I can reproduce on all platforms.

Sorry,still this did not feel being a driver for 18.0.1 & so wontfixing it at this time. Although please nominate for uplifts on branches as needed . Thanks

Comment 22

[Alex Keybl [:akeybl]]

I've pinged Anthony and roc in email about a backout.

Comment 23

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Attachment: Back out patch for bug 691061

Comment 24

[Mozilla RelEng Bot]

Try run for d397457363ea is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=d397457363ea
Results (out of 174 total builds):
    exception: 1
    success: 165
    warnings: 7
    failure: 1
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-d397457363ea

Comment 25

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f6a638c16bd4

Comment 26

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f6a638c16bd4

Comment 27

[Alex Keybl [:akeybl]]

(In reply to Anthony Jones (:kentuckyfriedtakahe) from comment #23)
> Created attachment 705198 [details] [diff] [review]
> Back out patch for bug 691061

Please nominate for uplift to FF19 with a risk evaluation as soon as possible. Thanks!

Comment 28

[Alex Keybl [:akeybl]]

(beta 5, the last opportunity to take this fix, is going to build tomorrow)

Comment 29

[Aaron Train [:aaronmt]]

Regression resolved on trunk, yes, please nominate.

Comment 30

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Comment on attachment 705198 [details] [diff] [review]
Back out patch for bug 691061

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 691061
User impact if declined: Broken JPEG when saving as PDF
Testing completed (on m-c, etc.): Already on m-c. This is a backout.
Risk to taking this patch (and alternatives if risky): Increased PDF size.
String or UUID changes made by this patch: None

Comment 31

[Alex Keybl [:akeybl]]

Comment on attachment 705198 [details] [diff] [review]
Back out patch for bug 691061

Approving for uplift. Thanks Anthony!

Comment 32

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/611fbc250e5b
https://hg.mozilla.org/releases/mozilla-beta/rev/6acde923ec99

(Sorry for skipping ahead a bit here wrt aurora, but it was a bit of a no-brainer)