Re-introduce an obsolete private browsing service in order to not break all Jetpack add-ons

RESOLVED FIXED in Firefox 20

Status

()

Firefox
Private Browsing
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

unspecified
Firefox 20
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

See bug 825471 for the sad sad details. :(
Assignee: nobody → ehsan
Blocks: 818800, 463027
OS: Mac OS X → All
Hardware: x86 → All
Created attachment 697195 [details] [diff] [review]
Patch (v1)
Attachment #697195 - Flags: review?(josh)
use the C-comment license header rather than the preprocessor one, and then you can get rid of the EXTRA_PP_COMPONENTS (preprocessing unnecessarily makes build slow).

Comment 3

5 years ago
Comment on attachment 697195 [details] [diff] [review]
Patch (v1)

Review of attachment 697195 [details] [diff] [review]:
-----------------------------------------------------------------

What Gerv said.
Attachment #697195 - Flags: review?(josh) → review+
(In reply to comment #3)
> What Gerv said.

Gerv?  ;-)
https://hg.mozilla.org/integration/mozilla-inbound/rev/26b70250e6fe
Blocks: 825471
I forgot half of the patch :(

https://hg.mozilla.org/integration/mozilla-inbound/rev/fcab6193a0fa
Looks like the tests are running again, and it's mostly just the private-browsing tests that are failing now, which is probably expected, since they're still trying to test the old stuff that isn't there anymore.
https://hg.mozilla.org/mozilla-central/rev/26b70250e6fe
https://hg.mozilla.org/mozilla-central/rev/fcab6193a0fa
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 20

Updated

5 years ago
Blocks: 826523
No longer blocks: 826523

Updated

5 years ago
Blocks: 825508

Comment 9

5 years ago
> See bug 825471 for the sad sad details. :(

I find 818800 comment 16 sad, too.
Keywords: dev-doc-needed

Updated

5 years ago
Keywords: dev-doc-needed

Comment 10

5 years ago
Sorry, linked: Bug 818800 comment 16
You need to log in before you can comment on or make changes to this bug.