Closed
Bug 826037
Opened 11 years ago
Closed 11 years ago
Re-introduce an obsolete private browsing service in order to not break all Jetpack add-ons
Categories
(Firefox :: Private Browsing, defect)
Firefox
Private Browsing
Tracking
()
RESOLVED
FIXED
Firefox 20
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
Attachments
(1 file)
4.96 KB,
patch
|
jdm
:
review+
|
Details | Diff | Splinter Review |
See bug 825471 for the sad sad details. :(
Assignee | ||
Updated•11 years ago
|
Updated•11 years ago
|
OS: Mac OS X → All
Hardware: x86 → All
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #697195 -
Flags: review?(josh)
Comment 2•11 years ago
|
||
use the C-comment license header rather than the preprocessor one, and then you can get rid of the EXTRA_PP_COMPONENTS (preprocessing unnecessarily makes build slow).
Comment 3•11 years ago
|
||
Comment on attachment 697195 [details] [diff] [review] Patch (v1) Review of attachment 697195 [details] [diff] [review]: ----------------------------------------------------------------- What Gerv said.
Attachment #697195 -
Flags: review?(josh) → review+
Assignee | ||
Comment 4•11 years ago
|
||
(In reply to comment #3) > What Gerv said. Gerv? ;-)
Assignee | ||
Comment 5•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/26b70250e6fe
Assignee | ||
Comment 6•11 years ago
|
||
I forgot half of the patch :( https://hg.mozilla.org/integration/mozilla-inbound/rev/fcab6193a0fa
Looks like the tests are running again, and it's mostly just the private-browsing tests that are failing now, which is probably expected, since they're still trying to test the old stuff that isn't there anymore.
Comment 8•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/26b70250e6fe https://hg.mozilla.org/mozilla-central/rev/fcab6193a0fa
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 20
Comment 9•11 years ago
|
||
> See bug 825471 for the sad sad details. :( I find 818800 comment 16 sad, too.
Keywords: dev-doc-needed
Updated•11 years ago
|
Keywords: dev-doc-needed
Comment 10•11 years ago
|
||
Sorry, linked: Bug 818800 comment 16
You need to log in
before you can comment on or make changes to this bug.
Description
•