826037 - Re-introduce an obsolete private browsing service in order to not break all Jetpack add-ons

Status: RESOLVED FIXED

(Firefox :: Private Browsing, defect)

Description

[(no longer active)]

See bug 825471 for the sad sad details. :(

Comment 1

[(no longer active)]

Attachment: Patch (v1)

Comment 2

[:Gavin Sharp [email: [e-mail]]]

use the C-comment license header rather than the preprocessor one, and then you can get rid of the EXTRA_PP_COMPONENTS (preprocessing unnecessarily makes build slow).

Comment 3

[Josh Matthews [:jdm]]

Comment on attachment 697195 [details] [diff] [review]
Patch (v1)

Review of attachment 697195 [details] [diff] [review]:
-----------------------------------------------------------------

What Gerv said.

Comment 4

[(no longer active)]

(In reply to comment #3)
> What Gerv said.

Gerv?  ;-)

Comment 5

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/26b70250e6fe

Comment 6

[(no longer active)]

I forgot half of the patch :(

https://hg.mozilla.org/integration/mozilla-inbound/rev/fcab6193a0fa

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Looks like the tests are running again, and it's mostly just the private-browsing tests that are failing now, which is probably expected, since they're still trying to test the old stuff that isn't there anymore.

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/26b70250e6fe
https://hg.mozilla.org/mozilla-central/rev/fcab6193a0fa

Comment 9

[Ben Bucksch (:BenB)]

> See bug 825471 for the sad sad details. :(

I find 818800 comment 16 sad, too.

Comment 10

[Ben Bucksch (:BenB)]

Sorry, linked: Bug 818800 comment 16