826160 - social UI not shown on earlier versions if same profile was ever used on FF20

Status: VERIFIED FIXED

(Firefox Graveyard :: SocialAPI, defect)

Description

[Mark Hammond [:markh] [:mhammond]]

I haven't actually tried these steps, but I think:

* Create a new profile using Aurora/Beta/17, enable Facebook.
* Start FF20 (Nightly) against the same profile and exit.
* Start Aurora/Beta/17 with the same profile.

Most of the Social UI will be invisible, as the social.active preference is false, as it was removed as part of the migration code in nightly.  eg, the sidebar may be open, but the toolbar and "tools" menu will not have any social elements.

Comment 1

[u279076]

Just expanding on the steps...

1. Start Firefox 18.0b7 with a new profile
2. Navigate to facebook.com and log in
3. Activate the Social API via www.facebook.com/about/messenger-for-firefox
> Social toolbar loaded, Social sidebar loaded, Menu item exists and is checked
4. Quit Firefox and start the latest Nightly with the same profile
> Social toolbar loaded, Social sidebar loaded, Menu item does not exist
5. Quit Nightly and start Firefox 18.0b7 with the same profile
> Social toolbar loaded, Social sidebar loaded, Menu item does not exist

Mark, can you clarify your steps to reproduce? I'm definitely seeing the menu item disappearing but I'm not seeing the toolbar disappearance.

(Tested on Windows 8 FWIW)

Comment 2

[Shane Caraveo (:mixedpuppy)]

Is it important to support this use case?

Comment 3

[u279076]

(In reply to Shane Caraveo (:mixedpuppy) from comment #2)
> Is it important to support this use case?

Potentially, if the UI "disappearance" happens on pave-over it might also happen on upgrade. Depending on how much UI disappears, it could also impede testing efforts.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Removing the clearing of the "active" pref should fix this, and I think there's no real downside to running that migration code multiple times when switching between versions.

Comment 5

[Mark Hammond [:markh] [:mhammond]]

Attachment: Don't remove the social.active preference on migration.

This will not fix profiles that have already been migrated, but I think that's OK.

Comment 6

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 704392 [details] [diff] [review]
Don't remove the social.active preference on migration.

[Triage Comment]
Let's take this on Aurora to avoid issues for people jumping between aurora/beta.

Comment 7

[Mark Hammond [:markh] [:mhammond]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/14d9f6853711

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/14d9f6853711

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/6cc4f8e1f617

Comment 10

[Mihai Morar, (:MihaiMorar)]

I confirm the fix is verified on FF 20.b2. I installed FF 19.b2 and FF 18.b5 and used same profile as the one used in FF 20 and Social API worked fine:

Mozilla/5.0 (Windows NT 6.1; WOW64; rv:20.0) Gecko/20100101 Firefox/20.0
Mozilla/5.0 (X11; Linux i686; rv:20.0) Gecko/20100101 Firefox/20.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:20.0) Gecko/20100101 Firefox/20.0

Comment 11

[Mihai Morar, (:MihaiMorar)]

Verified fixed on FF 21b1 too:

Mozilla/5.0 (Windows NT 6.1; WOW64; rv:21.0) Gecko/20100101 Firefox/21.0
Mozilla/5.0 (X11; Linux i686; rv:21.0) Gecko/20100101 Firefox/21.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:21.0) Gecko/20100101 Firefox/21.0

Builds ID: 20130401192816