826410 - nsHTMLMediaElement is missing nsIAudioChannelAgentCallback in its QI impl

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Fix

This leads to assertions in b2g debug builds.

Comment 1

[Johnny Stenback (:jst)]

Comment on attachment 697593 [details] [diff] [review]
Fix

We should also add a chrome caller check to nsHTMLMediaElement::CanPlayChanged() to make sure it can never be called by untrusted script. Please add that here as well so web pages can't interfere here and re-request approval on that patch.

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 697593 [details] [diff] [review]
Fix

https://hg.mozilla.org/integration/mozilla-inbound/rev/d1905a0ba1ed (with jst's requested change).

Comment 3

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/d1905a0ba1ed

Comment 5

[Marco Chen [:mchen]]

Bug caused by (feature/regressing bug #): Regression Bug 815069
User impact if declined: AudioChannelAgent will be broken on nsHTMLMediaElement (b2g18 branch). So Audio Competing Policy will be malfunctional.
Testing completed: Do the testing on b2g18.
Risk to taking this patch (and alternatives if risky): No.
String or UUID changes made by this patch: No.

This problem is exposed by bug Bug 857653, and since it is tef+. This should be a tef+ too.

Comment 6

[Justin Lebar (not reading bugmail)]

We need to set some flag in order for this to be considered for b2g uplift.  I'll set tef?; this blocks a blocker.

Comment 7

[Daniel Coloma:dcoloma]

as per comment 6 blocks a blocker

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/fd43cc45d4e2
https://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/e02af44c37c3