826489 - Add preference based settings to AsyncZoomPanController

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Oleg Romashin (:romaxa)]

It seems default AZPC tunnings does not work very well on other platforms, configurations due to different issues including Thread/Process configurations, device performance et.c.

I think AZPC should be tunable with gecko preferences, also it would be easy to do runtime tuning.

Comment 1

[Oleg Romashin (:romaxa)]

Attachment: Read AZPC settings from prefs

Comment 2

[Doug Sherk (:drs) (inactive)]

Comment on attachment 697775 [details] [diff] [review]
Read AZPC settings from prefs

Review of attachment 697775 [details] [diff] [review]:
-----------------------------------------------------------------

Naming needs changes. Everything right now is stylized as constants, i.e. "MY_CONSTANT_NAME", but we should be stylizing them as static globals, i.e. "sMyPrefVariable."

::: gfx/layers/ipc/AsyncPanZoomController.h
@@ +67,5 @@
>     * device DPI, before we start panning the screen. This is to prevent us from
>     * accidentally processing taps as touch moves, and from very short/accidental
>     * touches moving the screen.
>     */
> +  static float TOUCH_START_TOLERANCE;

While we're here, let's move this into AsyncPanZoomController.cpp as a static global.

::: gfx/layers/ipc/Axis.cpp
@@ +87,5 @@
>      mVelocity(0.0f),
>      mAcceleration(0),
>      mAsyncPanZoomController(aAsyncPanZoomController)
>  {
> +    InitAxisPrefs();

2 spaces.

Comment 3

[Doug Sherk (:drs) (inactive)]

It seems like the trend in similar code is to label globals (whether static or not) with "g" and static _member_ variables with "s", so in this case we want to use "g" and not "s."

Comment 4

[Oleg Romashin (:romaxa)]

Attachment: Read AZPC settings from prefs

Comment 5

[Doug Sherk (:drs) (inactive)]

Comment on attachment 699557 [details] [diff] [review]
Read AZPC settings from prefs

Review of attachment 699557 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good! Just...

::: gfx/layers/ipc/Axis.cpp
@@ +87,5 @@
>      mVelocity(0.0f),
>      mAcceleration(0),
>      mAsyncPanZoomController(aAsyncPanZoomController)
>  {
> +    InitAxisPrefs();

2 spaces.

Comment 6

[Oleg Romashin (:romaxa)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/220561604032
ups, machinary forgot to fix last comment :(
https://hg.mozilla.org/integration/mozilla-inbound/rev/453f1b333864

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/220561604032
https://hg.mozilla.org/mozilla-central/rev/453f1b333864