Closed Bug 826535 Opened 8 years ago Closed 8 years ago

Permaorange on every branch testAddonManager | Page title match - Expected /Add-ons for Android/, got "Add-ons for Firefox for Android" because the test depends on a web page title loaded over the network

Categories

(Testing :: General, defect)

ARM
Android
defect
Not set
normal

Tracking

(firefox19 disabled)

RESOLVED FIXED
Tracking Status
firefox19 --- disabled

People

(Reporter: philor, Unassigned)

References

Details

(Keywords: intermittent-failure)

Depending on loading things for tests over the network is ungood, unless you actually want your test results to be flaky (like bug 818782 flaky, or bug 817440 flaky).

Depending on the title of a third-party web page (where a third-party includes other bunches of us, like the AMO developers in this case, or webdevs updating www.mozilla.org the last time I got an entire suite killed for this sort of misbehavior) in a test is completely unacceptable.

http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/tests/testAddonManager.java.in#78 appears to be loading AMO, then checking that the title of AMO's page for Fennec addons is "Add-ons for Android".

https://tbpl.mozilla.org/php/getParsedLog.php?id=18448186&tree=Mozilla-Release and https://tbpl.mozilla.org/php/getParsedLog.php?id=18446568&tree=Mozilla-Aurora (nothing from trunk branches, because the test is already disabled on the trunk for bug 817440) say that now the title of that web page is "Add-ons for Firefox for Android" and the test will fail every time it runs.
Depends on: 817440
fixed by bug 817440
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.