BaselineCompiler: Compile constructors

RESOLVED FIXED

Status

()

defect
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: jandem, Assigned: jandem)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
Posted patch PatchSplinter Review
Just like Ion, when entering from the interpreter and are constructing, we have to create the object.
Attachment #697858 - Flags: review?(kvijayan)
Comment on attachment 697858 [details] [diff] [review]
Patch

Review of attachment 697858 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/ion/shared/IonFrames-x86-shared.h
@@ +79,5 @@
>      }
>  
> +    Value thisv() {
> +        return argv()[0];
> +    }

This should be added to IonFrames-arm.h as well.
Attachment #697858 - Flags: review?(kvijayan) → review+
(Assignee)

Comment 2

6 years ago
https://hg.mozilla.org/projects/ionmonkey/rev/618c1544ac42

(In reply to Kannan Vijayan [:djvj] from comment #1)
> This should be added to IonFrames-arm.h as well.

Oops, good catch.
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.