826745 - [META] ASSERTION from "make mozmill" test run of DEBUG BUILD of TB (comm-central)

Status: RESOLVED WORKSFORME

(Thunderbird :: General, defect)

Description

[ISHIKAWA, Chiaki]

While testing thunderbird (debug build of comm-central source) by
running "make mozmill" locally, I noticed many ASSERTION messages.
I think they are more or less (if not all of them) are
symptoms of bugs or bad design (failure to consider corner cases, etc.)

The constructs / code paths that lead to these warnings ought to be
fixed.

The following is the output of 

grep ASSERTION: mozmill-log-TB-debug-build.txt | sort | uniq -c | sort -n -r

     52 ###!!! ASSERTION: Accessible tree was modified after it was removed! Huh?: 'Error', file /TB-NEW/TB-3HG/new-src/mozilla/accessible/src/base/NotificationController.cpp, line 498
     49 ###!!! ASSERTION: Bad position passed to nsJISx4051LineBreaker::Next: 'aLen > aPos', file /TB-NEW/TB-3HG/new-src/mozilla/intl/lwbrk/src/nsJISx4501LineBreaker.cpp, line 791
     31 ###!!! ASSERTION: Component Manager being held past XPCOM shutdown.: 'cnt == 0', file /TB-NEW/TB-3HG/new-src/mozilla/xpcom/build/nsXPComInit.cpp, line 670
     28 ###!!! ASSERTION: Overwriting an existing document channel!: '(loadFlags & nsIChannel::LOAD_REPLACE) || !(mDocumentRequest.get())', file /TB-NEW/TB-3HG/new-src/mozilla/uriloader/base/nsDocLoader.cpp, line 491
     13 ###!!! ASSERTION: Uh, IsInModalState() called w/o a reachable top window?: 'Error', file /TB-NEW/TB-3HG/new-src/mozilla/dom/base/nsGlobalWindow.cpp, line 6918
      6 ###!!! ASSERTION: not-null m_mime_delivery_state: 'm_mime_delivery_state != nullptr', file /TB-NEW/TB-3HG/new-src/mailnews/compose/src/nsMsgAttachmentHandler.cpp, line 973
      4 ###!!! ASSERTION: URI is empty: '!aURI.IsEmpty()', file /TB-NEW/TB-3HG/new-src/mozilla/rdf/base/src/nsRDFService.cpp, line 884
      4 ###!!! ASSERTION: No node for the accessible tree walker!: 'aContent', file /TB-NEW/TB-3HG/new-src/mozilla/accessible/src/base/TreeWalker.cpp, line 46
      3 ###!!! ASSERTION: Shouldn't be trying to draw with a singular matrix!: '!aMatrix.IsSingular()', file ../../../../dist/include/Layers.h, line 734
      3 ###!!! ASSERTION: Flush during accessible tree update!: '!accService->IsProcessingRefreshDriverNotification()', file /TB-NEW/TB-3HG/new-src/mozilla/layout/base/nsPresShell.cpp, line 3792
      2 ###!!! ASSERTION: Unbinding the unbound accessible!: 'mAccessibleCache.GetWeak(aAccessible->UniqueID())', file /TB-NEW/TB-3HG/new-src/mozilla/accessible/src/generic/DocAccessible.cpp, line 1325
      2 ###!!! ASSERTION: RemoveCurrentDraftMessage msgSend is null.: 'msgSend', file /TB-NEW/TB-3HG/new-src/mailnews/compose/src/nsMsgCompose.cpp, line 3891
      2 ###!!! ASSERTION: Existing entry in StartupCache.: 'entry == nullptr', file /TB-NEW/TB-3HG/new-src/mozilla/startupcache/StartupCache.cpp, line 352
      1 ###!!! ASSERTION: fix this: '!(*pResultKey != nsMsgKey_None && resultThreadId && *resultThreadId == nsMsgKey_None)', file /TB-NEW/TB-3HG/new-src/mailnews/base/src/nsMsgDBView.cpp, line 6749
      1 ###!!! ASSERTION: Existing entry in disk StartupCache.: 'zipItem == nullptr', file /TB-NEW/TB-3HG/new-src/mozilla/startupcache/StartupCache.cpp, line 356

TIA

cf. There was another case of an Assertion message coming from
nsExternalHelperAppService.cpp.

But I already filed a bugzilla entry for it:
Bug 826742 - nsExternalHelperAppService.cpp : Assertion: Empty
aExtension parameter! (from DEBUG BUILD of TB)

Comment 1

[ISHIKAWA, Chiaki]

Today's status of warning messages from "make mozmill" run of 
DEBUG Build of TB.

    149 ###!!! ASSERTION: Empty aExtension parameter!: '!aExtension.IsEmpty()', file /COMM-CENTRAL/comm-central/mozilla/uriloader/exthandler/nsExternalHelperAppService.cpp, line 2723

      Filed a bug as
      Bug 826742 - nsExternalHelperAppService.cpp : Assertion: Empty aExtension  parameter! (from DEBUG BUILD of TB)

     33 ###!!! ASSERTION: Component Manager being held past XPCOM shutdown.: 'cnt == 0', file /COMM-CENTRAL/comm-central/mozilla/xpcom/build/nsXPComInit.cpp, line 682
     31 ###!!! ASSERTION: Overwriting an existing document channel!: '(loadFlags & nsIChannel::LOAD_REPLACE) || !(mDocumentRequest.get())', file /COMM-CENTRAL/comm-central/mozilla/uriloader/base/nsDocLoader.cpp, line 476
     13 ###!!! ASSERTION: Uh, IsInModalState() called w/o a reachable top window?: 'Error', file /COMM-CENTRAL/comm-central/mozilla/dom/base/nsGlobalWindow.cpp, line 7200
      9 ###!!! ASSERTION: UpdateLabelValue was called for wrong accessible!: 'xulLabel', file /COMM-CENTRAL/comm-central/mozilla/accessible/src/base/nsAccessibilityService.cpp, line 417
      6 ###!!! ASSERTION: not-null m_mime_delivery_state: 'm_mime_delivery_state != nullptr', file /COMM-CENTRAL/comm-central/mailnews/compose/src/nsMsgAttachmentHandler.cpp, line 971
      4 ###!!! ASSERTION: URI is empty: '!aURI.IsEmpty()', file /COMM-CENTRAL/comm-central/mozilla/rdf/base/src/nsRDFService.cpp, line 884

Bug 829882 - ASSERTION: URI is empty: '!aURI.IsEmpty()', file /TB-NEW/TB-3HG/new-src/mozilla/rdf/base/src/nsRDFService.cpp, line 884

      3 ###!!! ASSERTION: Flush during accessible tree update!: '!accService->IsProcessingRefreshDriverNotification()', file /COMM-CENTRAL/comm-central/mozilla/layout/base/nsPresShell.cpp, line 3817
      2 ###!!! ASSERTION: Unbinding the unbound accessible!: 'mAccessibleCache.GetWeak(aAccessible->UniqueID())', file /COMM-CENTRAL/comm-central/mozilla/accessible/src/generic/DocAccessible.cpp, line 1314
      2 ###!!! ASSERTION: Shouldn't be trying to draw with a singular matrix!: '!aMatrix.IsSingular()', file ../../../../dist/include/Layers.h, line 786
      2 ###!!! ASSERTION: RemoveCurrentDraftMessage msgSend is null.: 'msgSend', file /COMM-CENTRAL/comm-central/mailnews/compose/src/nsMsgCompose.cpp, line 3887
      1 ###!!! ASSERTION: fix this: '!(*pResultKey != nsMsgKey_None && resultThreadId && *resultThreadId == nsMsgKey_None)', file /COMM-CENTRAL/comm-central/mailnews/base/src/nsMsgDBView.cpp, line 6674


The following assertion n the old list was fixed by
Bug 827061

     49 ###!!! ASSERTION: Bad position passed to nsJISx4051LineBreaker::Next: 'aLen > aPos', file /TB-NEW/TB-3HG/new-src/mozilla/intl/lwbrk/src/nsJISx4501LineBreaker.cpp, line 791

Comment 2

[Magnus Melin [:mkmelin]]

mozmill is gone.