826819 - Show different "Add tab" icons for normal and private tabs in Tabs Panel

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[Sriram Ramasubramanian [:sriram]]

Currently just the same "+" is used for adding a new tab/private tab in Tabs Panel. We need a visual demarcation.

Comment 1

[Sriram Ramasubramanian [:sriram]]

Attachment: Part 1: Change the border

Yay! Holo theme Yay!
This changes the border from a gradient+shadow to a plain solid color.

Comment 2

[Sriram Ramasubramanian [:sriram]]

Attachment: Part 2: Replace private icons

The cute little private tab icons -- more like mask of zorro than a acting company's mask :D

Comment 3

[Sriram Ramasubramanian [:sriram]]

Attachment: Part 2: Replace private icons

Previous patch missed the tablet part. That's fixed here.

Comment 4

[Sriram Ramasubramanian [:sriram]]

Attachment: Part 3: Remove shadow

This should have gone in with the first patch. This removes the unused shadow.

Comment 5

[Sriram Ramasubramanian [:sriram]]

Attachment: Part 4: GB icons

These icons are for the "5+more" menu.

Comment 6

[Sriram Ramasubramanian [:sriram]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/81672e5fce70
https://hg.mozilla.org/integration/mozilla-inbound/rev/84d9d94d34c4
https://hg.mozilla.org/integration/mozilla-inbound/rev/96afe9c985c0
https://hg.mozilla.org/integration/mozilla-inbound/rev/19bf3d706500

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/81672e5fce70
https://hg.mozilla.org/mozilla-central/rev/84d9d94d34c4
https://hg.mozilla.org/mozilla-central/rev/96afe9c985c0
https://hg.mozilla.org/mozilla-central/rev/19bf3d706500

Comment 8

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 700570 [details] [diff] [review]
Part 1: Change the border

[Approval Request Comment]
Bug caused by (feature/regressing bug #): New Feature.
User impact if declined: Old tabs-switcher with orange highlight.
Testing completed (on m-c, etc.): Landed in m-c on 01/12
Risk to taking this patch (and alternatives if risky): Very low. This is just a theme change.
String or UUID changes made by this patch: -

Comment 9

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 700616 [details] [diff] [review]
Part 2: Replace private icons

[Approval Request Comment]
Bug caused by (feature/regressing bug #): New Feature.
User impact if declined: No new private-tab icon that's cute.
Testing completed (on m-c, etc.): Landed in m-c on 01/12
Risk to taking this patch (and alternatives if risky): Very low. Just image replacements.
String or UUID changes made by this patch: -

Comment 10

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 700640 [details] [diff] [review]
Part 3: Remove shadow

[Approval Request Comment]
Bug caused by (feature/regressing bug #): New Feature.
User impact if declined: None. Removing a redundant resource.
Testing completed (on m-c, etc.): Landed in m-c on 01/12
Risk to taking this patch (and alternatives if risky): None. Removing a redundant resource.
String or UUID changes made by this patch: -

Comment 11

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 700723 [details] [diff] [review]
Part 4: GB icons

[Approval Request Comment]
Bug caused by (feature/regressing bug #): New Feature.
User impact if declined: New private tab icons for GB phones.
Testing completed (on m-c, etc.): Landed in m-c on 01/12
Risk to taking this patch (and alternatives if risky): None. These are the GB comrades.
String or UUID changes made by this patch: -

Comment 12

[bhavana bajaj [:bajaj]]

Comment on attachment 700570 [details] [diff] [review]
Part 1: Change the border

Approving all the patches here considering they are low risk and are needed for private browsing feature landing in FF20 .

Comment 13

[Cristian Nicolae (:xti)]

Private "add tab" button is changed on the latest Nightly.

Firefox for Android
Version: 21.0a1 (2013-01-23)
Device: Galaxy R
OS: Android 2.3.4

Comment 14

[Sriram Ramasubramanian [:sriram]]

Aurora:
https://hg.mozilla.org/releases/mozilla-aurora/rev/75bfa8bf7eb8
https://hg.mozilla.org/releases/mozilla-aurora/rev/3c645d92feba
https://hg.mozilla.org/releases/mozilla-aurora/rev/a606fb9aa999
https://hg.mozilla.org/releases/mozilla-aurora/rev/e638e4db2e66

Comment 15

[Catalin Suciu [:csuciu]]

Verified fixed on Aurora 20.0a2 (2013-01-28)