826992 - Avoid hardcoded clientId in SafeBrowser.jsm

Status: RESOLVED FIXED

(Toolkit :: Safe Browsing, defect)

Description

[Mike Hommey [:glandium]]

We currently have this in SafeBrowser.jsm:

#ifdef USE_HISTORIC_SAFEBROWSING_ID
    let clientID = "navclient-auto-ffox";
#else
    let clientID = Services.appinfo.name;
#endif

Building Firefox as a xulrunner application makes it having to choose between all xulrunner applications using the navclient-auto-ffox clientID, or Firefox using "firefox" as a clientID.

This also led mobile to add their own copy of the file just to do that:
#ifdef USE_HISTORIC_SAFEBROWSING_ID
    let clientID = "navclient-auto-ffox";
#else
#expand    let clientID = __MOZ_APP_UA_NAME__;
#endif

All in all, this would benefit from being handled with an app pref.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Avoid hardcoded clientId in SafeBrowser.jsm

Comment 2

[Mike Hommey [:glandium]]

Attachment: Avoid hardcoded clientId in SafeBrowser.jsm

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 698255 [details] [diff] [review]
Avoid hardcoded clientId in SafeBrowser.jsm

Looks OK to me, but since we are removing the mobile SafeBrowsing component (which we wanted to do anyway) I want GCP to take a look too.

Comment 4

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ff82d1a3955e

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/ff82d1a3955e

Comment 7

[Kartikaya Gupta (email:[e-mail])]

This bug causes a regression in reader mode, among other things, because the change breaks the mobile prefs file. See https://bugzilla.mozilla.org/show_bug.cgi?id=830308#c6 for details.

Comment 8

[Gian-Carlo Pascutto [:gcp]]

Backed out:
https://hg.mozilla.org/mozilla-central/rev/b72d2af170aa

Comment 9

[Mike Hommey [:glandium]]

Relanded with a fixup to mobile.js.
https://hg.mozilla.org/integration/mozilla-inbound/rev/d56a171a1325

Comment 10

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/d56a171a1325