Closed
Bug 827017
Opened 12 years ago
Closed 12 years ago
Make it easier to edit disabled form fields
Categories
(SeaMonkey :: Composer, defect)
SeaMonkey
Composer
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.18
People
(Reporter: neil, Assigned: neil)
References
Details
Attachments
(1 file)
|
4.79 KB,
patch
|
iannbugzilla
:
review+
mconley
:
feedback+
|
Details | Diff | Splinter Review |
As of bug 816340 we can now catch clicks on disabled form fields if we're careful. This makes it minusculely easier to edit them, and significantly easier in all tags mode.
|
Assignee | |
Comment 1•12 years ago
|
||
* Added the click handler to the XUL instead of mucking around with script (this is the bit that allows us to see clicks on disabled form controls) * Separated the click and dblclick handlers because only editor's interested in single clicks so this simplifies the code
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #698291 -
Flags: review?(iann_bugzilla)
Attachment #698291 -
Flags: feedback?(mconley)
Comment on attachment 698291 [details] [diff] [review] Proposed patch Tested against SM and seems to be no issues in the code. r=me for SM and shared Not run it against TB try server to see if causes any test failures though.
Attachment #698291 -
Flags: review?(iann_bugzilla) → review+
|
||
Comment 3•12 years ago
|
||
Comment on attachment 698291 [details] [diff] [review] Proposed patch Review of attachment 698291 [details] [diff] [review]: ----------------------------------------------------------------- I think this looks OK. Certainly good to get rid of that hack, and make editor.js less aware / caring of what application we're in.
Attachment #698291 -
Flags: feedback?(mconley) → feedback+
|
|
Assignee | |
Comment 4•12 years ago
|
||
Pushed comm-central changeset 5afc408aa274.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
||
Updated•12 years ago
|
Target Milestone: --- → seamonkey2.18
You need to log in
before you can comment on or make changes to this bug.
Description
•