Closed Bug 897685 Opened 11 years ago Closed 11 years ago

Double-click opens properties dialog

Categories

(MailNews Core :: Composition, defect)

Product:
MailNews Core
Component:
Composition
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(thunderbird24 fixed, seamonkey2.19 wontfix, seamonkey2.20 affected, seamonkey2.21 fixed, seamonkey2.22 unaffected)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 24.0
Tracking Flags:
Tracking Status
thunderbird24 --- fixed
seamonkey2.19 --- wontfix
seamonkey2.20 --- affected
seamonkey2.21 --- fixed
seamonkey2.22 --- unaffected

People

(Reporter: neil, Assigned: neil)

References

Details

(Keywords: regression)

Attachments

(1 file)

Proposed patch
2.87 KB, patch
iannbugzilla
: review+
mconley
: feedback+
standard8
: feedback+
standard8
: approval-comm-beta+
Details | Diff | Splinter Review 
Due to bug 879838 the change from checking clickCount to using dblclick events broke double-clicking on text, which now opens the properties dialog for the containing element. Although this is fixed on trunk we have to work around it on branches.
Attached patch Proposed patch — — Splinter Review 
Assignee: nobody → neil
Status: NEW → ASSIGNED

        Attachment #780634 -
        Flags: review?(iann_bugzilla)

        Attachment #780634 -
        Flags: feedback?(mconley)

    
  

        Attachment #780634 -
        Flags: review?(iann_bugzilla) → review+

    
    

    
  
Comment on attachment 780634 [details] [diff] [review]
Proposed patch

Sorry for the wait!

        Attachment #780634 -
        Flags: feedback?(mconley) → feedback+

    
    

    
  
Comment on attachment 780634 [details] [diff] [review]
Proposed patch

[Approval Request Comment]
Regression caused by (bug #): 827017 (because of bug 879838)
User impact if declined: Unexpected property dialogs when double-clicking
Testing completed (on m-c, etc.): N/A 879838 was fixed in Gecko 25
Risk to taking this patch (and alternatives if risky): Low
String changes made by this patch: None

        Attachment #780634 -
        Flags: feedback?(mbanner)

        Attachment #780634 -
        Flags: approval-comm-beta?

    
    

    
  
Moving to mailnews as this affects both of us.
Component: Composer → Composition
Product: SeaMonkey → MailNews Core
Version: SeaMonkey 2.19 Branch → 24

    
    

    
  
Comment on attachment 780634 [details] [diff] [review]
Proposed patch

a=Standard8

        Attachment #780634 -
        Flags: feedback?(mbanner)

        Attachment #780634 -
        Flags: feedback+

        Attachment #780634 -
        Flags: approval-comm-beta?

        Attachment #780634 -
        Flags: approval-comm-beta+

    
    

    
  
This already landed as part of:

http://hg.mozilla.org/releases/comm-beta/rev/4748f12ac8a1
Status: ASSIGNED → RESOLVED
Closed: 11 years ago

          status-seamonkey2.21:
          affected → fixed

          status-thunderbird24:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 24.0

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: