827176 - java.lang.NullPointerException: at org.mozilla.gecko.GeckoInputConnection.notifyTextChange(GeckoInputConnection.java) at org.mozilla.gecko.GeckoInputConnection.endBatchEdit(GeckoInputConnection.java)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Keyboards and IME, defect)

Description

[Scoobidiver (away)]

There are 9 crashes in 19.0a2 and 20.0a1.

Here is a crash report: bp-59379700-1357-47fa-a033-eaf3b2130103.

java.lang.NullPointerException
	at org.mozilla.gecko.GeckoInputConnection.notifyTextChange(GeckoInputConnection.java:260)
	at org.mozilla.gecko.GeckoInputConnection.endBatchEdit(GeckoInputConnection.java:88)
	at com.android.internal.view.IInputConnectionWrapper.executeMessage(IInputConnectionWrapper.java:400)
	at com.android.internal.view.IInputConnectionWrapper$MyHandler.handleMessage(IInputConnectionWrapper.java:77)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at android.os.Looper.loop(Looper.java:137)
	at android.app.ActivityThread.main(ActivityThread.java:4921)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:511)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1038)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:805)
	at dalvik.system.NativeStart.main(Native Method)

More reports at:
https://crash-stats.mozilla.com/report/list?signature=java.lang.NullPointerException%3A+at+org.mozilla.gecko.GeckoInputConnection.notifyTextChange%28GeckoInputConnection.java%29

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Properly reset GeckoInputConnection states during focus (v1)

Comment 2

[Chris Peterson [:cpeterson]]

Comment on attachment 700672 [details] [diff] [review]
Properly reset GeckoInputConnection states during focus (v1)

Review of attachment 700672 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, but maybe given the resetState() method a less generic name. It is a little confusing because it is NOT related to NOTIFY_IME_RESETINPUTSTATE.

\o/ for removing the last static variables in GeckoInputConnection! :D

Comment 3

[(inactive) Jim Chen [:jchen] [:darchons]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/118918b2774e

Leaving open for nom Aurora/Beta.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/118918b2774e

Comment 5

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 700672 [details] [diff] [review]
Properly reset GeckoInputConnection states during focus (v1)

[Approval Request Comment]

Bug caused by (feature/regressing bug #): N/A

User impact if declined: Crash when changing input field focus

Testing completed (on m-c, etc.): Locally, m-c

Risk to taking this patch (and alternatives if risky): Very small; patch only performs clean up and does not introduce new functionality

String or UUID changes made by this patch: None

Comment 6

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 700672 [details] [diff] [review]
Properly reset GeckoInputConnection states during focus (v1)

approving for branches, low risk and early in beta cycle.

Comment 7

[(inactive) Jim Chen [:jchen] [:darchons]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/dfc821302c6c

https://hg.mozilla.org/releases/mozilla-beta/rev/a8f593ceae74