829318 - Problems using Grooveshark sidebar search field

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Keyboards and IME, defect)

Description

[Wesley Johnston (:wesj)]

When I type the first letter on grooveshark, the cursor doesn't move. So if I type 'cat', i get 'atc'. Tapping on the box also doesn't move the cursor (unless i do it several times).

STR:
1.) Open grooveshark.com's touch site
2.) Tap menu button in top right
3.) Tap search field
4.) Type a letter

Expected: cursor is after letter
Actual: cursor is still at start of line

Comment 1

[Wesley Johnston (:wesj)]

I wouldn't be surprised if this was due to the draggable cursor as well.

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

Okay, using the latest Nightly I cannot reproduce the original problem, but there is another problem where the keyboad doesn't show up, and I have a patch for that.

Comment 3

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Don't mess with mIMEState during focus/blur (v1)

Basically the keyboard is not showing because we reset mIMEState during focus but notifyIMEEnabled is not guaranteed to be called afterwards, so mIMEState never gets set to a proper value.

Patch removes the code that resets mIMEState and adds comments to explain the issue.

This makes a great argument for having IME tests; this kind of regression could have been avoided :)

Comment 4

[Chris Peterson [:cpeterson]]

Comment on attachment 703065 [details] [diff] [review]
Don't mess with mIMEState during focus/blur (v1)

Review of attachment 703065 [details] [diff] [review]:
-----------------------------------------------------------------

One less special case! \o/

Comment 5

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 703065 [details] [diff] [review]
Don't mess with mIMEState during focus/blur (v1)

[Approval Request Comment]

Bug caused by (feature/regressing bug #): Bug 827176

User impact if declined: User annoyance; keyboard will not display for some input fields

Testing completed (on m-c, etc.): Locally

Risk to taking this patch (and alternatives if risky): Very small risk; patch fixes a regression caused by bug 827176, and because bug 827176 is being uplifted to Aurora and Beta, this patch should be uplifted as well

String or UUID changes made by this patch: None

Comment 6

[Lukas Blakk [:lsblakk] use ?needinfo]

Triage drive-by: waiting for this to land on central and marked fixed before approving.

Comment 7

[(inactive) Jim Chen [:jchen] [:darchons]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f21022822e49

Sorry for the delay!

Comment 8

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/f21022822e49

Comment 9

[Alex Keybl [:akeybl]]

Comment on attachment 703065 [details] [diff] [review]
Don't mess with mIMEState during focus/blur (v1)

Please land asap to make it into Beta 3. Thanks!

Comment 10

[(inactive) Jim Chen [:jchen] [:darchons]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/ac84cba81cc9

https://hg.mozilla.org/releases/mozilla-beta/rev/e2f2ded04714