Closed
Bug 827265
Opened 11 years ago
Closed 11 years ago
[toolbox] Command buttons have a left and right border on OS X when selected
Categories
(DevTools :: Framework, defect, P1)
Tracking
(firefox20 verified)
VERIFIED
FIXED
Firefox 21
Tracking | Status | |
---|---|---|
firefox20 | --- | verified |
People
(Reporter: vporof, Assigned: vporof)
References
Details
Attachments
(2 files, 1 obsolete file)
58.02 KB,
image/png
|
Details | |
843 bytes,
patch
|
paul
:
review+
bajaj
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Bug 827031 took care of the background, however the border remained on OS X.
Assignee | ||
Comment 1•11 years ago
|
||
If the borders should be transparent, then this is enough.
Attachment #698607 -
Flags: review?(paul)
Assignee | ||
Comment 2•11 years ago
|
||
This also works.
Assignee: nobody → vporof
Attachment #698607 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #698607 -
Flags: review?(paul)
Attachment #698609 -
Flags: review?(paul)
Updated•11 years ago
|
Attachment #698609 -
Flags: review?(paul) → review+
Updated•11 years ago
|
Whiteboard: [land-in-fx-team]
Comment 3•11 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/9306e34e7511 This will need an uplift to aurora.
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
Comment 4•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/9306e34e7511
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 21
Comment 5•11 years ago
|
||
Comment on attachment 698609 [details] [diff] [review] v2 [Approval Request Comment] Bug caused by (feature/regressing bug #): new feature (toolbox) User impact if declined: theme glitch Testing completed (on m-c, etc.): m-c Risk to taking this patch (and alternatives if risky): 0 (one CSS line) String or UUID changes made by this patch: no
Attachment #698609 -
Flags: approval-mozilla-aurora?
Updated•11 years ago
|
Attachment #698609 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Updated•11 years ago
|
Whiteboard: [land-in-aurora]
Comment 6•11 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/5a285669d28e
status-firefox20:
--- → fixed
Updated•11 years ago
|
Whiteboard: [land-in-aurora]
Comment 7•11 years ago
|
||
Verified as fixed on the latest Nightly and Aurora - there are no right and left borders for the command buttons. Verified on Windows 7, Ubuntu 12.10 and Mac OS X 10.8.2: Mozilla/5.0 (Windows NT 6.1; rv:21.0) Gecko/20130210 Firefox/21.0 (20130210031150) Mozilla/5.0 (Windows NT 6.1; rv:20.0) Gecko/20130210 Firefox/20.0 (20130210042017) Mozilla/5.0 (X11; Linux i686; rv:21.0) Gecko/20130211 Firefox/21.0 (20130211031055) Mozilla/5.0 (X11; Linux i686; rv:20.0) Gecko/20130210 Firefox/20.0 (20130210042017) Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:21.0) Gecko/20130211 Firefox/21.0 (20130211031055) Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:20.0) Gecko/20130211 Firefox/20.0 (20130211042016)
Status: RESOLVED → VERIFIED
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•