Create mozpool python package

RESOLVED FIXED

Status

Release Engineering
General
P2
normal
RESOLVED FIXED
5 years ago
7 months ago

People

(Reporter: armenzg, Assigned: armenzg)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

5 years ago
We should also modify b2g_panda.py to use this once completed.
(Assignee)

Updated

5 years ago
Priority: -- → P2
(Assignee)

Updated

5 years ago
Blocks: 829211
Mozpool's not on pypi yet, but I've no problem seeing it uploaded.  Please add Mark and I as package admins there, too.

From our vidyo conversation, if this bug involves writing a Mozpool client library (separate from the mozharness-based library jhopkins wrote), it'd be great to see that library included directly in the mozpool repo.  Then users can install 'mozpool', and use either the client or server portion, as they prefer.  It also means that we can make non-backward-compatible API changes to both client and server at the same time, and even test that they work together correctly.
(Assignee)

Updated

5 years ago
Priority: P2 → P1
(Assignee)

Updated

5 years ago
Priority: P1 → P2
(Assignee)

Updated

5 years ago
Blocks: 831327
(Assignee)

Comment 2

5 years ago
Created attachment 702859 [details] [diff] [review]
mozpool package
Attachment #702859 - Flags: review?(dustin)
Comment on attachment 702859 [details] [diff] [review]
mozpool package

Review of attachment 702859 [details] [diff] [review]:
-----------------------------------------------------------------

I think this should be in the same Python package as the rest of mozpool - so no distinct setup.py.  It should be *the same* project - so no separate CHANGES.txt, no separate README.txt, etc.  Just a few extra Python files added to mozpool.
Attachment #702859 - Flags: review?(dustin) → review-
I see mozpoolclient-0.1.0 added to the python packages in puppetagain.  Is that this, or is that jhopkins' mozpool client?  I noticed that it uses the package name 'mozpool', which will make it impossible to install in the same virtualenv as mozpool.
(Assignee)

Comment 5

5 years ago
Created attachment 706539 [details] [diff] [review]
mozpoolclient package

We spoke on IRC and we decided that is best to make the client part lightweight and not need all other packages needed by the whole mozpool stack.

This package only needs "request".

I have tested the package and it works.
Attachment #706539 - Flags: review?(dustin)
(Assignee)

Updated

5 years ago
Attachment #702859 - Attachment is obsolete: true
Comment on attachment 706539 [details] [diff] [review]
mozpoolclient package

Looks good to me!
Attachment #706539 - Flags: review?(dustin) → review+
(Assignee)

Updated

5 years ago
No longer blocks: 829211
(Assignee)

Comment 7

5 years ago
http://hg.mozilla.org/build/mozpool/rev/3d10d9547e73
Blocks: 834850
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Assignee)

Updated

5 years ago
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Updated

5 years ago
Attachment #706539 - Flags: checked-in+
(Assignee)

Comment 8

5 years ago
Created attachment 707236 [details] [diff] [review]
make requests necessary

I don't know at which point I lost this line in my patches.
Attachment #707236 - Flags: review?(dustin)
Attachment #707236 - Flags: review?(dustin) → review+
(Assignee)

Comment 9

5 years ago
Comment on attachment 707236 [details] [diff] [review]
make requests necessary

http://hg.mozilla.org/build/mozpool/rev/e352d25b75b0
Attachment #707236 - Flags: checked-in+
(Assignee)

Comment 10

5 years ago
Thanks!
Status: REOPENED → RESOLVED
Last Resolved: 5 years ago5 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
Component: Tools → General
Product: Release Engineering → Release Engineering
You need to log in before you can comment on or make changes to this bug.