Closed Bug 827628 Opened 7 years ago Closed 5 years ago

groupon.com.br doesn't recognize B2G UA as mobile

Categories

(Web Compatibility :: Mobile, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(firefox40 fixed)

RESOLVED FIXED
Tracking Status
firefox40 --- fixed

People

(Reporter: lmandel, Assigned: karlcow)

References

()

Details

(Whiteboard: [country-br][serversniff][sitewait])

Attachments

(2 files)

groupon.com.br serves a desktop site to B2G. Bug 819210 added an UA override for this domain. The override should be removed once the domain serves mobile content to B2G. This bug tracks the evangelism for the site to recognize the B2G UA and the removal of the override at that time.
Whiteboard: [uaoverride]
Whiteboard: [uaoverride] → [uaoverride] [country-br]
https://mobile.twitter.com/MozWebCompat/status/371968585364963328
Assignee: nobody → hsteen
Status: NEW → ASSIGNED
Whiteboard: [uaoverride] [country-br] → [uaoverride] [country-br][serversniff][sitewait]
Assignee: hsteen → nobody
Status: ASSIGNED → NEW
See Also: → 945943
I will try to reach out the international group first Bug 945943
Let see where it leads.

> I'm forwarding this issue to the appropriate department for further assistance. They will get back to you as soon as possible.
I reported this internally. Trying to get someone on the mobile product team to come participate.
Thanks for the help Trek!
Trek, any news about this?
Thanks.
Assignee: nobody → kdubost
Status: NEW → ASSIGNED
Flags: needinfo?(trek.glowacki)
This was reportedly fixed, but it appears that applied only to our European platform. Are you seeing this in the US?
Flags: needinfo?(trek.glowacki) → needinfo?(lmandel)
I'm located in Canada but confirm that groupon.com.br directs me to a mobile site while groupon.com directs me to a desktop site on Firefox OS.
Flags: needinfo?(lmandel)
Trek, Lawrence,

nope ;)
There is UA override going on for groupon in Brazil. So it gives the illusion it is fixed. When you remove the UA override you get the desktop site.

https://hg.mozilla.org/mozilla-central/file/tip/b2g/app/ua-update.json.in#l28
    28   // bug 827628, groupon.com.br
    29   "groupon.com.br": "\\(Mobile#(Android; Mobile",
Flags: needinfo?(trek.glowacki)
Flags: needinfo?(lmandel)
Right. I read comment 7 and for some reason thought that we had already removed the override. I confirm that without the override Firefox is still served the desktop site for groupon.com.br.
Flags: needinfo?(lmandel)
I'm a Groupon employee who is the right person to track this down. I've sent a proposed fix to the appropriate team internally and will report back after they have a chance to take a look. Thanks!
Hey Adam, I can handle the patch.  Do note that it might not be possible to update every phone in the field with the patch (it's carriers responsibility to provide updates).  Going forward, new phones using fxos could have the proper UA.
We should verify that with this patch applied (or atleast with using a UA switcher add on) that we get the correct mobile site when visiting groupon.com.br.
Attachment #8588043 - Flags: review?(kdubost)
Adam, please confirm when groupon.com.br correctly identifies the b2g UA.  Then, the patch is ready and waiting in the wings on our side.
Flags: needinfo?(ageitgey)
Comment on attachment 8588043 [details] [diff] [review]
Remove UA override for groupon.com.br Bug #827628

Review of attachment 8588043 [details] [diff] [review]:
-----------------------------------------------------------------

This is good. Thanks Nick.
Attachment #8588043 - Flags: review?(kdubost) → review+
Lawrence, I granted the review for the UA removal. (Hope it's fine with you)
The site has been fixed.
Flags: needinfo?(trek.glowacki)
Flags: needinfo?(lmandel)
Flags: needinfo?(ageitgey)
(In reply to Karl Dubost :karlcow from comment #17)
> Lawrence, I granted the review for the UA removal. (Hope it's fine with you)

+1

> The site has been fixed.

\o/
Flags: needinfo?(lmandel)
Whiteboard: [uaoverride] [country-br][serversniff][sitewait] → [uaoverride] [country-br][serversniff][sitewait][checkin-needed]
https://hg.mozilla.org/integration/b2g-inbound/rev/7ec555c68f66
Whiteboard: [uaoverride] [country-br][serversniff][sitewait][checkin-needed] → [uaoverride][country-br][serversniff][sitewait]
https://hg.mozilla.org/mozilla-central/rev/7ec555c68f66
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Removing the UA override whiteboard field for any confusion in the future if we have to reopen.
Whiteboard: [uaoverride][country-br][serversniff][sitewait] → [country-br][serversniff][sitewait]
Product: Tech Evangelism → Web Compatibility
You need to log in before you can comment on or make changes to this bug.