827628 - groupon.com.br doesn't recognize B2G UA as mobile

Status: RESOLVED FIXED

(Web Compatibility :: Site Reports, defect)

Description

[Lawrence Mandel [:lmandel] (use needinfo)]

groupon.com.br serves a desktop site to B2G. Bug 819210 added an UA override for this domain. The override should be removed once the domain serves mobile content to B2G. This bug tracks the evangelism for the site to recognize the B2G UA and the removal of the override at that time.

Comment 1

[Hallvord R. M. Steen [:hallvors]]

https://mobile.twitter.com/MozWebCompat/status/371968585364963328

Comment 2

[Karl Dubost💡 :karlcow]

I will try to reach out the international group first Bug 945943

Comment 3

[Karl Dubost💡 :karlcow]

Let see where it leads.

> I'm forwarding this issue to the appropriate department for further assistance. They will get back to you as soon as possible.

Comment 4

[Trek Glowaki]

I reported this internally. Trying to get someone on the mobile product team to come participate.

Comment 5

[Adam Stevenson [:adamopenweb]]

Thanks for the help Trek!

Comment 6

[Karl Dubost💡 :karlcow]

Trek, any news about this?
Thanks.

Comment 7

[Trek Glowaki]

This was reportedly fixed, but it appears that applied only to our European platform. Are you seeing this in the US?

Comment 8

[Lawrence Mandel [:lmandel] (use needinfo)]

I'm located in Canada but confirm that groupon.com.br directs me to a mobile site while groupon.com directs me to a desktop site on Firefox OS.

Comment 9

[Karl Dubost💡 :karlcow]

Trek, Lawrence,

nope ;)
There is UA override going on for groupon in Brazil. So it gives the illusion it is fixed. When you remove the UA override you get the desktop site.

https://hg.mozilla.org/mozilla-central/file/tip/b2g/app/ua-update.json.in#l28
    28   // bug 827628, groupon.com.br
    29   "groupon.com.br": "\\(Mobile#(Android; Mobile",

Comment 10

[Lawrence Mandel [:lmandel] (use needinfo)]

Right. I read comment 7 and for some reason thought that we had already removed the override. I confirm that without the override Firefox is still served the desktop site for groupon.com.br.

Comment 11

[Hallvord R. M. Steen [:hallvors]]

Attachment: Screenshot from Flame smartphone

Comment 12

[Adam Geitgey]

I'm a Groupon employee who is the right person to track this down. I've sent a proposed fix to the appropriate team internally and will report back after they have a chance to take a look. Thanks!

Comment 13

[(not reading bugmail) Nick Desaulniers [:\n]]

Hey Adam, I can handle the patch.  Do note that it might not be possible to update every phone in the field with the patch (it's carriers responsibility to provide updates).  Going forward, new phones using fxos could have the proper UA.

Comment 14

[(not reading bugmail) Nick Desaulniers [:\n]]

Attachment: Remove UA override for groupon.com.br Bug #827628

We should verify that with this patch applied (or atleast with using a UA switcher add on) that we get the correct mobile site when visiting groupon.com.br.

Comment 15

[(not reading bugmail) Nick Desaulniers [:\n]]

Adam, please confirm when groupon.com.br correctly identifies the b2g UA.  Then, the patch is ready and waiting in the wings on our side.

Comment 16

[Karl Dubost💡 :karlcow]

Comment on attachment 8588043 [details] [diff] [review]
Remove UA override for groupon.com.br Bug #827628

Review of attachment 8588043 [details] [diff] [review]:
-----------------------------------------------------------------

This is good. Thanks Nick.

Comment 17

[Karl Dubost💡 :karlcow]

Lawrence, I granted the review for the UA removal. (Hope it's fine with you)
The site has been fixed.

Comment 18

[Lawrence Mandel [:lmandel] (use needinfo)]

(In reply to Karl Dubost :karlcow from comment #17)
> Lawrence, I granted the review for the UA removal. (Hope it's fine with you)

+1

> The site has been fixed.

\o/

Comment 19

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/7ec555c68f66

Comment 20

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7ec555c68f66

Comment 21

[Karl Dubost💡 :karlcow]

Removing the UA override whiteboard field for any confusion in the future if we have to reopen.