828096 - Work - Fix horizontal scrolling on start page

Status: RESOLVED FIXED

(Firefox for Metro Graveyard :: General, defect)

Description

[Yuan Wang(:Yuan) – Mobile Firefox Design Lead]

Currently only touching tiles could trigger horizontal scrolling. 
We need to support horizontal scrolling when touchpoint is located at background.

Except the URL bar area, other parts on the start page should all be sensitive to users' touch input for scrolling.

Comment 1

[Matt Brubeck (:mbrubeck)]

Attachment: work-around patch

For some reason touchstart events are being dispatched to the <browser> instead of to the fixed-position #start-container element in front of the browser.  I'm not yet sure why (I couldn't reproduce the problem in a simple test file), but collapsing the browser works around the problem for now.

I'm still looking into the underlying problem; I'm also experimenting with simplifying the layout of the StartUI and browsers, by making them part of the same stack (instead of floating the StartUI inside the position:fixed #tray container).

Comment 2

[Matt Brubeck (:mbrubeck)]

Attachment: remove dead code

While I was investigating this bug I came across some unused properties, and some code that is disabled (and would break if we enabled it).  Shall we kill these?

Comment 3

[Frank Yan (:fryn)]

Comment on attachment 699881 [details] [diff] [review]
work-around patch

Review of attachment 699881 [details] [diff] [review]:
-----------------------------------------------------------------

Okay as a workaround. :)

Comment 4

[Frank Yan (:fryn)]

Comment on attachment 699892 [details] [diff] [review]
remove dead code

Review of attachment 699892 [details] [diff] [review]:
-----------------------------------------------------------------

I generally dislike bundling unrelated code refactoring into bugs, since it makes it unclear in the changelog/history what one pushed or backed out and more difficult to search for.

That said, I'd rather have these things landed than not, and I appreciate you doing them. Thanks! :)

Comment 5

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/projects/elm/rev/d76d4148d79f
https://hg.mozilla.org/projects/elm/rev/2a34d17ada04

Thanks for the reviews!  I'll lean more toward opening separate bugs for cleanup work in the future.

Comment 6

[Matt Brubeck (:mbrubeck)]

Resolving bugs in the Firefox for Metro product that are fixed on the elm branch.  Sorry for the bugspam.  Search your email for "bugspam-elm" if you want to find and delete all of these messages at once.