The default bug view has changed. See this FAQ.

[Needinfo] One user can needinfo multiple times from the same person

RESOLVED FIXED

Status

()

bugzilla.mozilla.org
Extensions: Needinfo
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: ypwalter, Assigned: dkl)

Tracking

Production

Details

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
https://bugzilla.mozilla.org/show_bug.cgi?id=827535

mvines: 	needinfo 	ggrisco@codeaurora.org
shuang: 	needinfo 	ggrisco@codeaurora.org
wachen: 	needinfo 	ggrisco@codeaurora.org
wachen: 	needinfo 	ggrisco@codeaurora.org

Also, one can still add more needinfo from the same person.
(Reporter)

Updated

4 years ago
Blocks: 827535
(Reporter)

Comment 1

4 years ago
There are two aspects of this bug:
1. multiple people requesting from the same person:   Acceptable
2. same people requesting multiple times from another person:   Strange
No longer blocks: 827535
See Also: → bug 827535
(Assignee)

Comment 2

4 years ago
Created attachment 703582 [details] [diff] [review]
Patch to disallow same requestee muliple times for needinfo (v1)
Assignee: nobody → dkl
Status: NEW → ASSIGNED
Attachment #703582 - Flags: review?(glob)
Comment on attachment 703582 [details] [diff] [review]
Patch to disallow same requestee muliple times for needinfo (v1)

r=glob, with the following to be fixed on commit:

>+                next if $flag->requestee->login != $needinfo_flag->{requestee};

that needs to be 'ne' not '!='.
Attachment #703582 - Flags: review?(glob) → review+
(Assignee)

Comment 4

4 years ago
Thanks

Committing to: bzr+ssh://dlawrence%40mozilla.com@bzr.mozilla.org/bmo/4.0   
modified extensions/Needinfo/Extension.pm
Committed revision 8446.

Committing to: bzr+ssh://dlawrence%40mozilla.com@bzr.mozilla.org/bmo/4.2   
modified extensions/Needinfo/Extension.pm
Committed revision 8510.
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.