828243 - Cleanup wasDone, wasInProgress and endTime usage

Status: RESOLVED FIXED

(Firefox :: Downloads Panel, defect)

Description

[Asaf Romano (gone)]

Attachment: patch

I also found out that we don't show the end-time at all in the library (and that we're going to have a nightmare with history downloads regarding that matter), but I'll file that in a separate bug.

Comment 1

[Asaf Romano (gone)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/262ee9b69e38

Comment 2

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/262ee9b69e38

Comment 3

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Comment on attachment 699693 [details] [diff] [review]
patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Downloads panel feature
User impact if declined: performance issues
Testing completed (on m-c, etc.): m-c
Risk to taking this patch (and alternatives if risky): Limited to the feature
String or UUID changes made by this patch: none

Comment 4

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/50f3e4082f97

Comment 5

[Simona Badau, Desktop QA]

Verified as fixed on Firefox 20 on Windows 7, Ubuntu 12.04 and Mac OS X 10.8:
Build ID: 20130326150557
Mozilla/5.0 (Windows NT 6.1; rv:20.0) Gecko/20100101 Firefox/20.0
Mozilla/5.0 (X11; Linux i686; rv:20.0) Gecko/20100101 Firefox/20.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:20.0) Gecko/20100101 Firefox/20.0