Library downloads view hangs with thousands of entries

RESOLVED FIXED

Status

()

Firefox
Downloads Panel
P1
normal
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mak, Unassigned)

Tracking

({meta})

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

5 years ago
We still need to work on performance improvements
(Reporter)

Updated

5 years ago
Priority: -- → P1
(Reporter)

Updated

5 years ago
Depends on: 827268
(Reporter)

Updated

5 years ago
Keywords: meta
(Reporter)

Updated

5 years ago
Depends on: 826991
(Reporter)

Updated

5 years ago
Depends on: 827405
(Reporter)

Updated

5 years ago
Depends on: 827428
No longer depends on: 826991
No longer blocks: 824260
(Reporter)

Comment 1

5 years ago
Some recent work that is about to land
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/mak77@bonardo.net-02e43b34326c/

Alice, willing to test this and report improvements?
Flags: needinfo?(alice0775)
(Reporter)

Comment 2

5 years ago
On my system, my profile (550 downloads) opens instantly, Alice's test profile (4500 downloads) takes 2 seconds.  Measured from clicking "Show all downloads" from the downloads button.
(Reporter)

Comment 3

5 years ago
out of 1650ms, that is the total time spent in invalidateContainer, 1235 are due to appendChild, 373 are spent in AddDownloadData (88 self, 274 in creating DownloadElementShell), 42 in nsStyleSet::FileRules
(Reporter)

Comment 4

5 years ago
As Mano pointed out today, we are spending some time in getDownloadState on placesNode() setter, that must be investigated, most of this time goes into _getAnnotation, but that should just do a Map lookup, a Map set and return a value. Maybe the Map is a perf hog?

Comment 5

5 years ago
(In reply to Marco Bonardo [:mak] from comment #1)
> Some recent work that is about to land
> http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/mak77@bonardo.net-
> 02e43b34326c/
> 
> Alice, willing to test this and report improvements?
1.  It takes about 3 sec to render download view after Download clicked in Library.
2. It takes  about 1 sec to shutdown Browser, Bug 825242
3. No more freeze browser when open link 825242, Bug 827268

Everything improved.
Flags: needinfo?(alice0775)
Depends on: 828111
(Reporter)

Comment 6

5 years ago
(In reply to Alice0775 White from comment #5)
> Everything improved.

Thanks, glad we are moving the right direction.
Depends on: 828243
(Reporter)

Comment 7

5 years ago
Remeasured with bug 828111, the time on my system is about 300ms and we also have plans to reduce it further (reducing annos from 3 to 2). I think we are almost done here.
(Reporter)

Updated

5 years ago
No longer depends on: 827428
(Reporter)

Comment 8

5 years ago
Fixed by dependencies.

The most offending hangs should be gone, there is still bug 824260 that may improve window close times and bug 826991 that may bring a small gain, though there's no reason to keep this open to track single small improvements.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.