828337 - Maps app is not re-localized when device locale is changed

Status: RESOLVED FIXED

(Tech Evangelism Graveyard :: Preinstalled B2G Apps, defect, P1)

Description

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Attachment: screenshot

1. set device to PT-BR
2. launch maps

Expected: app should be localized
Actual: app is not localized for the agreement, the about page, the countries

Note: 
This bug is more for tracking purposes on an app that isn't ours.
Question: do we need to add support for 3rd party apps to be localized as well?

Comment 1

[Axel Hecht [:Pike]]

(In reply to Naoki Hirata :nhirata from comment #0)
<...>
> Question: do we need to add support for 3rd party apps to be localized as
> well?

Not beyond the scope in which our js infrastructure is licensed to be used by external webapps, IMHO.

Comment 3

[chris hofmann]

nominating so at least we can get an understanding about where maps localization bugs should go. does anyone know where the base and localized content lives, what the localization process is, and who is responsible?

these questions are a mystery to the mozilla l10n team.

Comment 4

[Axel Hecht [:Pike]]

We're having a code drop of the maps app in the gaia repo, which is closed-source code. I don't see a way for us to modify the content of the application.zip drop, including the localizations that are within it.

Comment 5

[Alex Keybl [:akeybl]]

We're going to mark this as tef+ but NPOTB.

(In reply to chris hofmann from comment #3)
> nominating so at least we can get an understanding about where maps
> localization bugs should go. does anyone know where the base and localized
> content lives, what the localization process is, and who is responsible?
> 
> these questions are a mystery to the mozilla l10n team.

This sounds like an external app, so wouldn't the l10n be completed by our partner? Peter - can you confirm?

Comment 7

[Peter Dolanjski [:pdol]]

Karen, can you figure out who needs to be made aware of this on the partner end?

Comment 8

[chris hofmann]

it would also be interesting to understand how the phone tells a cloud app which locale it wants if available, and what to do in fallback situations.  are we providing a spec to app developers for this?

Comment 9

[Thomas Elin [:relaas]]

I've notified the proper contacts at Nokia about this issue and requested a fix. Once i've heard back from them i will reply to this thread. 

Will offer resources from Apps partner Engineering if needed.

Comment 10

[AndyT]

Ok. This problem seems different than we got from the e-mail report. This is a partial duplication of 830772. 

We (@Nokia) will at least localize the Agreement (=Welcome) page asap.

Comment 11

[Bartosz Piec]

What about the rest of the interface? And what about the other languages?

Comment 13

[AndyT]

Other languages will also be taken care of. Rest of interface too.

Comment 14

[AndyT]

Request to unflag this as a blocker for blocking-b2g:
This issue does not happen the very first time you open the app: it will always take the system's locale to set the language.
If the user then changes the system's locale, the Maps app still shows the previous system locale (because we inadvertently store any locale setting). But this a not a common use case, furthermore, the user still gets a user interface to also change the language in the settings of the app.

Comment 15

[Jason Smith [:jsmith]]

Tested this. Here's what I'm seeing:

1. The privacy policy screen on first launch is always English
2. Post the privacy policy the locale text matches the phone's locale
3. Switch to another locale and restart app process - app locale doesn't change to system's locale

[1] and [3] makes this remain as a blocker.

(In reply to AndyT from comment #14)
> Request to unflag this as a blocker for blocking-b2g:
> This issue does not happen the very first time you open the app: it will
> always take the system's locale to set the language.
> If the user then changes the system's locale, the Maps app still shows the
> previous system locale (because we inadvertently store any locale setting).
> But this a not a common use case, furthermore, the user still gets a user
> interface to also change the language in the settings of the app.

We expose the functionality and this causes a user foot gun. I'd have to check with product on what the likelihood of language switching is, but given that we expose and provide the functionality, I'm inclined to say this remains as a blocker.

Comment 16

[Dylan Oliver [:doliver]]

Andy, is it feasible to translate the Welcome screen for the chosen locale? Since the user is required to accept a disclaimer here, I think that is going to be a blocker. 

I'm less concerned about the locale switching (item 3 in comment #15) as there is a workaround inside the Maps app settings to change the language. Andy has said they will fix this but don't feel it to be a v1.0.x blocker. I would agree with that.

We should probably spin off a separate bug for the Welcome screen and let this one be about locale switching.

Comment 17

[Jason Smith [:jsmith]]

Oh...there's a way to switch the locale within the maps app? Didn't know that. If so, that's fine.

Comment 18

[Dylan Oliver [:doliver]]

(In reply to Dylan Oliver [:doliver] from comment #16)
> We should probably spin off a separate bug for the Welcome screen and let
> this one be about locale switching.

Andy let me know that bug 831583 already exists for the localization of the Welcome screen, so I nominated that one for blocking TEF.

For this one, I'm sending back to triage and recommending that we do not block. The localization does work properly for the locale that is set when you run the app for the first time. It just does not automatically re-localize if you later change your locale. The workaround for that situation is to change the language setting from within the Maps app.

Comment 19

[Lukas Blakk [:lsblakk] use ?needinfo]

Given that this can be fixed at a later date, not blocking.

Comment 20

[Chris Lee [:clee]]

How are we handling packaged apps for l10n changes?  (Regardless if it's preset out of the box or if a user changes their locale)

Comment 21

[Jason Smith [:jsmith]]

(In reply to Chris Lee [:clee] from comment #20)
> How are we handling packaged apps for l10n changes?  (Regardless if it's
> preset out of the box or if a user changes their locale)

My guess is that the app developer would update their packaged app on marketplace to get l10n changes in. Then, the user would have to update their packaged app to have the updated l10n changes.

Comment 22

[Karen Ward [:kward]]

Apps Review will notify the developer.  This app supports different languages, but keeps the language setting at the time of installation.

Comment 23

[Andrew Williamson [:eviljeff]]

(In reply to [e-mail] from comment #22)
> Apps Review will notify the developer.  This app supports different
> languages, but keeps the language setting at the time of installation.

Are we requiring that a change be made so that a system change of language results in an in-app change of language?

Comment 24

[chris hofmann]

(In reply to Andrew Williamson [:eviljeff] from comment #23)
> (In reply to [e-mail] from comment #22)
> > Apps Review will notify the developer.  This app supports different
> > languages, but keeps the language setting at the time of installation.
> 
> Are we requiring that a change be made so that a system change of language
> results in an in-app change of language?

I think that would be the expectation of most users.  If they changed their preferred language, they would like to see that reflected across all the apps on the phone, independent of who provides the apps, and where the content for those apps resides, either locally on the phone or from "the cloud".

I think the question goes back to determining if and when we can come up with a consistent api for doing this to meet user expectations.

Comment 25

[Andrew Williamson [:eviljeff]]

(In reply to chris hofmann from comment #24)
> I think the question goes back to determining if and when we can come up
> with a consistent api for doing this to meet user expectations.

That's one of my reservations - /do/ we have a consistent api for doing this?

Comment 26

[Andrew Williamson [:eviljeff]]

karen - has a decision been made on whether this is a *requirement* or a recommendation?

Comment 27

[Donovan Preston [:fzzzy]]

I'm confused why this was elevated to critical when it got set to minus all the way back in February? IIRC the consensus at the time was that since it chooses the correct language the first time the app is launched, that it wasn't important enough to block on. Did something change?

Comment 28

[:Harald Kirschner :digitarald]

I created this example code to dynamically react to language changes without certified API: https://gist.github.com/digitarald/5549799

I personally don't see it as P1 feature, as retrieving the user language on app launch is sufficient.

Comment 29

[Dylan Oliver [:doliver]]

(In reply to Harald Kirschner :digitarald from comment #28)
> I personally don't see it as P1 feature, as retrieving the user language on
> app launch is sufficient.

Agreed, but it's also been almost three months since we've seen an update from Andy on this one. Is this something we can expect to be ready in the 1.1 release timeframe?

Comment 32

[Karen Ward [:kward]]

To test language support in an app:
1.	Set desired language in Firefox OS system settings
2.	Install and launch application
If the selected language is supported, it will always be displayed the first time the app is launched.
for v1.0.1 All of the app including agreement, the about page, the countries should display in the local language based on this test procedure:
1.	Uninstall the app by long pressing the app's icon in the launcher and then tapping the red x
2.	Change the language in Firefox OS system settings
3.	Install the app again and launch
Depending on how the app is designed [1], apps may not always detect locale changes after they've first been launched.  We're working with developers to optimize this experience, but this issue should be low impact since most users will set their desired language once when first setting up the phone.

Andrew - please retest this and close if it passes. Thanks

Comment 33

[Karen Ward [:kward]]

App reported fixed by Nokia on May 3 - " This issue has been fixed in HERE Maps v1.8.58 which is already in Marketplace"

Comment 34

[Jason Smith [:jsmith]]

comment 32 has absolutely nothing to do with this bug. This bug is talking about the case where the user changes the locale of the phone while the app is installed.

Comment 35

[Jason Smith [:jsmith]]

(In reply to [e-mail] from comment #33)
> App reported fixed by Nokia on May 3 - " This issue has been fixed in HERE
> Maps v1.8.58 which is already in Marketplace"

I don't understand this comment. Do you mean this bug is fixed now with the new packaged app that is submitted to marketplace?

Comment 36

[Jeni]

Issue repros on 
Leo Build ID: 20130620160852
Gecko: /rev/
Gaia: ef85283d8a041cecf9a37348cf6a0b580804f3d6
Platform Version: 18.1

Here Maps is not fully localized in Spanish and Portuguese languages

Comment 37

[Axel Hecht [:Pike]]

Jeni, that sounds like a different issue than this bug, please report that separately?

Comment 38

[Jeni]

(In reply to Axel Hecht [:Pike] from comment #37)
> Jeni, that sounds like a different issue than this bug, please report that
> separately?

Ok created.  https://bugzilla.mozilla.org/show_bug.cgi?id=887539 if you need it

Comment 40

[AndyT]

This fix will be in the next Maps release. (probably within two weeks)

Comment 41

[Cheng-An, XIONG]

(In reply to AndyT from comment #40)
> This fix will be in the next Maps release. (probably within two weeks)

fix release has been ready?

Comment 42

[Andrew Overholt [:overholt]]

Since this doesn't look like it's regressed since v1.0.1, I don't see how we'd block v1.1 here.

Comment 43

[Jason Smith [:jsmith]]

Pulling nom per comment 42

Comment 44

[ZieL]

It should be fixed with our next update this or the next week. 

Leo

Comment 45

[Joe Cheng [:jcheng] (please needinfo)]

ping. wonder if the version with the fix is provided? Thanks

Comment 46

[Pawel Wojciechowski]

Yes, HERE Maps version 1.8.77 with the fix is already available on the Firefox Marketplace.

Comment 47

[Jason Smith [:jsmith]]

Sounds like we can close this then per comment 46.