Closed
Bug 829052
Opened 11 years ago
Closed 11 years ago
progress is NaN when doing appcache update
Categories
(Core Graveyard :: DOM: Apps, defect)
Tracking
(blocking-basecamp:+, firefox19 wontfix, firefox20 wontfix, firefox21 fixed, b2g18 fixed)
People
(Reporter: julienw, Assigned: ferjm)
Details
Attachments
(1 file)
4.57 KB,
patch
|
fabrice
:
review+
julienw
:
feedback+
|
Details | Diff | Splinter Review |
STR: * install a recent enough gaia so that here maps is there with its update working (ie with bug 828939 fixed) * update here maps => the byte number doesn't change in the notification I added logs and saw that we get NaN in app.progress.
Comment 1•11 years ago
|
||
julien, what's the user impact here? Hard to know if we want to basecamp+ here.
Flags: needinfo?(felash)
Comment 2•11 years ago
|
||
Jonas indicated impact in person. This blocks because the user does have to knowledge of what resources they've used during downloading.
Flags: needinfo?(felash)
Reporter | ||
Comment 3•11 years ago
|
||
And I actually wrote it : "=> the byte number doesn't change in the notification" :-)
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → ferjmoreno
Assignee | ||
Comment 4•11 years ago
|
||
Attachment #700650 -
Flags: review?(fabrice)
Assignee | ||
Comment 5•11 years ago
|
||
Comment on attachment 700650 [details] [diff] [review] v1 Julien, this patch works for me, but it would be great if you could also test it. Thanks!
Attachment #700650 -
Flags: feedback?(felash)
Assignee | ||
Comment 6•11 years ago
|
||
Comment on attachment 700650 [details] [diff] [review] v1 Review of attachment 700650 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/apps/src/Webapps.jsm @@ +21,5 @@ > Cu.import("resource://gre/modules/SystemMessagePermissionsChecker.jsm"); > Cu.import("resource://gre/modules/AppDownloadManager.jsm"); > > function debug(aMsg) { > + dump("-*-*- Webapps.jsm : " + aMsg + "\n"); Oops...
Updated•11 years ago
|
Attachment #700650 -
Flags: review?(fabrice) → review+
Comment 7•11 years ago
|
||
Reading the patch indicates to me and comments above indicates to me ferjm confirmed this as a bug, which means we should mark this basecamp+ after talking with Jonas. Putting a reminder on for Jonas so that we don't forget to mark the bug as such.
Flags: needinfo?(jonas)
Comment 8•11 years ago
|
||
I'll talk with Fabrice in the morning so that we can test this together with Julien.
Keywords: qawanted
QA Contact: jsmith
Comment 9•11 years ago
|
||
Btw - When Dietrich tested this, he's getting 0 KB, not NaN KB. But that's still a problem if it's always 0 KB.
blocking-basecamp: ? → +
Reporter | ||
Comment 10•11 years ago
|
||
Yep, 0 KB is what is displayed, NaN is what we get from the platform. I guess we have a safeguard somewhere :)
Reporter | ||
Comment 11•11 years ago
|
||
Comment on attachment 700650 [details] [diff] [review] v1 This fixes the bug for me, thanks Fernando !
Attachment #700650 -
Flags: feedback?(felash) → feedback+
Assignee | ||
Comment 12•11 years ago
|
||
Thanks for testing Julien! I'll push it as soon as inbound is open again.
Assignee | ||
Comment 13•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/56e67e5e1548
Comment 14•11 years ago
|
||
https://hg.mozilla.org/releases/mozilla-b2g18/rev/06aaf552938e
Status: NEW → RESOLVED
Closed: 11 years ago
status-b2g18:
--- → fixed
status-firefox19:
--- → wontfix
status-firefox20:
--- → wontfix
Resolution: --- → FIXED
Updated•11 years ago
|
status-firefox21:
--- → fixed
Target Milestone: --- → mozilla21
Updated•7 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•