829052 - progress is NaN when doing appcache update

Status: VERIFIED FIXED

(Core Graveyard :: DOM: Apps, defect)

Description

[Julien Wajsberg [:julienw]]

STR:
* install a recent enough gaia so that here maps is there with its update working (ie with bug 828939 fixed)
* update here maps
=> the byte number doesn't change in the notification

I added logs and saw that we get NaN in app.progress.

Comment 1

[Doug Turner (:dougt)]

julien, what's the user impact here?  Hard to know if we want to basecamp+ here.

Comment 2

[Jason Smith [:jsmith]]

Jonas indicated impact in person. This blocks because the user does have to knowledge of what resources they've used during downloading.

Comment 3

[Julien Wajsberg [:julienw]]

And I actually wrote it : "=> the byte number doesn't change in the notification" :-)

Comment 4

[Fernando Jiménez Moreno [:ferjm]]

Attachment: v1

Comment 5

[Fernando Jiménez Moreno [:ferjm]]

Comment on attachment 700650 [details] [diff] [review]
v1

Julien, this patch works for me, but it would be great if you could also test it. Thanks!

Comment 6

[Fernando Jiménez Moreno [:ferjm]]

Comment on attachment 700650 [details] [diff] [review]
v1

Review of attachment 700650 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/apps/src/Webapps.jsm
@@ +21,5 @@
>  Cu.import("resource://gre/modules/SystemMessagePermissionsChecker.jsm");
>  Cu.import("resource://gre/modules/AppDownloadManager.jsm");
>  
>  function debug(aMsg) {
> +  dump("-*-*- Webapps.jsm : " + aMsg + "\n");

Oops...

Comment 7

[Jason Smith [:jsmith]]

Reading the patch indicates to me and comments above indicates to me ferjm confirmed this as a bug, which means we should mark this basecamp+ after talking with Jonas.

Putting a reminder on for Jonas so that we don't forget to mark the bug as such.

Comment 8

[Jason Smith [:jsmith]]

I'll talk with Fabrice in the morning so that we can test this together with Julien.

Comment 9

[Jason Smith [:jsmith]]

Btw - When Dietrich tested this, he's getting 0 KB, not NaN KB. But that's still a problem if it's always 0 KB.

Comment 10

[Julien Wajsberg [:julienw]]

Yep, 0 KB is what is displayed, NaN is what we get from the platform. I guess we have a safeguard somewhere :)

Comment 11

[Julien Wajsberg [:julienw]]

Comment on attachment 700650 [details] [diff] [review]
v1

This fixes the bug for me, thanks Fernando !

Comment 12

[Fernando Jiménez Moreno [:ferjm]]

Thanks for testing Julien! I'll push it as soon as inbound is open again.

Comment 13

[Fernando Jiménez Moreno [:ferjm]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/56e67e5e1548

Comment 14

[Andrea Marchesini [:baku]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/06aaf552938e

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/56e67e5e1548

Comment 16

[Jason Smith [:jsmith]]

Verified on 1/21 build.