829198 - Context menu items are using a bad font size

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Wesley Johnston (:wesj)]

We should use a better layout here. Something that matches the default system ones better.

Comment 1

[Wesley Johnston (:wesj)]

Attachment: Patch

Simple fix. I'll post a screenshot

Comment 2

[Wesley Johnston (:wesj)]

Attachment: Screenshot comparing old and new menus

This compares the old and new menu items. It also shows a native menu (the urlbar one) for comparison. I'll test this on an GB phone too....

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 700593 [details] [diff] [review]
Patch

Uplift!

Comment 4

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/00175d6d4839

Comment 5

[Wesley Johnston (:wesj)]

Comment on attachment 700593 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Been there forever since the native transition
User impact if declined: Context menus look less native and its hard to fit much text in them.
Testing completed (on m-c, etc.): Landed on mc today
Risk to taking this patch (and alternatives if risky): Tiny change, but we're using system layouts. Could affect different devices differently.
String or UUID changes made by this patch: None.

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/00175d6d4839

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/00175d6d4839

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/00175d6d4839

Comment 9

[Alex Keybl [:akeybl]]

Comment on attachment 700593 [details] [diff] [review]
Patch

Given the risk evaluation and the fact that this is a longstanding issue, let's fix this in Firefox 21 to start.

Comment 10

[Ioana Chiorean]

Firefox 21.0a1 (2013-01-17)

The font is now as expected - as the new in the scrreenshots. Marking bug as Verified Fixed