838400 - Context menus are too compact Android 2.3 HTC Sense

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Kevin Brosnan [Ex-Mozilla]]

Attachment: Screenshot

Context menus are very compact and not touch friendly at all on HTC Sense Android 2.3 devices. See screenshot.

Comment 1

[Wesley Johnston (:wesj)]

Kevin, you mind trying this build:

http://people.mozilla.com/~wjohnston/contextmenufix.apk

I'm trying setting a minHeight on the rows in Java (overriding the one set in xml).

Comment 2

[Kevin Brosnan [Ex-Mozilla]]

Attachment: screenshot from a test build by wesj

This looks good wesj.

Comment 3

[Wesley Johnston (:wesj)]

Attachment: Patch

Comment 4

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 719606 [details] [diff] [review]
Patch

Looks good to me.

Comment 5

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7a2ee65ecfa0

Comment 6

[Gregory Szorc [:gps]]

https://hg.mozilla.org/mozilla-central/rev/7a2ee65ecfa0

Comment 7

[bhavana bajaj [:bajaj]]

(In reply to Wesley Johnston (:wesj) from comment #5)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/7a2ee65ecfa0

Wes, can you please request approval for uplift on aurora in this ? It looks to be ready :)

Comment 8

[Wesley Johnston (:wesj)]

Comment on attachment 719606 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 829198
User impact if declined: Hard to tap context menus on some devices
Testing completed (on m-c, etc.): Landed on mc long ago
Risk to taking this patch (and alternatives if risky): Low risk. Just enforcing a minimum size
String or UUID changes made by this patch: None.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/405d840dabbf