Closed Bug 829258 Opened 7 years ago Closed 7 years ago

Include missing @2x images in pinstripe/jar.mn

Categories

(Firefox :: Downloads Panel, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 21
Tracking Status
firefox20 --- fixed

People

(Reporter: mconley, Assigned: mconley)

References

Details

Attachments

(1 file, 1 obsolete file)

Bug 812255 was awesome, because it landed sweet new hi-dpi graphics for the Downloads Panel.

What wasn't awesome, was that it forgot to include those graphics in jar.mn.
Attached patch Patch v1 (obsolete) — Splinter Review
Assignee: nobody → mconley
Attachment #700649 - Flags: review?(mak77)
Attached patch Patch v2Splinter Review
We need download-summary too.
Attachment #700649 - Attachment is obsolete: true
Attachment #700649 - Flags: review?(mak77)
Summary: Actually include buttons@2x.png in jar.mn → Include missing @2x images in pinstripe/jar.mn
Comment on attachment 700655 [details] [diff] [review]
Patch v2

Review of attachment 700655 [details] [diff] [review]:
-----------------------------------------------------------------

thanks!
Attachment #700655 - Flags: review?(mak77) → review+
Comment on attachment 700655 [details] [diff] [review]
Patch v2

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Downloads panel feature
User impact if declined: incomplete ui
Testing completed (on m-c, etc.): m-i (merge pending)
Risk to taking this patch (and alternatives if risky): limited to the feature
String or UUID changes made by this patch: none
Attachment #700655 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/bafcf4095439
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 21
Attachment #700655 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.