829392 - Trusted UI doesn't close after completion of a purchase and we don't reload marketplace app to start app download

Status: RESOLVED FIXED

(Marketplace Graveyard :: Payments/Refunds, defect, P1)

Description

[krupa raj[:krupa]]

steps to reproduce:
1. Log into marketplace-dev on your unagi phone
2. Navigate to the details page  for Private Yacht
3. Click on the purchase button
4. Set up your pin
5. Confirm SMS
6. Click Buy to confirm purchase

expected behavior:
After purchase is complete, trusted UI is closed and User navigates back to the details page and is prompted to download the app

observed behavior:
Trusted UI has the message- "Your paymnet is complete. This window will now close" and remains open. Clicking on the 'x' doesnt close it.

Comment 1

[Jason Smith [:jsmith]]

The X button issue I believe is already tracked in a separate bug you filed that's a regression from an identity patch.

Kumar - are you remembering to call payment success piece here? I need to know asap if this is client-side that's failing.

Comment 2

[Kumar McMillan [:kumar]]

Yes, we do call the payment success handler. I know because it works most of the time :) There is some kind of edge case here where it does not work but I am unable to consistently reproduce it. I am also blocked from testing on Unagi because logins don't work for me. I have seen the error above on desktop but only randomly.

Comment 3

[Jason Smith [:jsmith]]

I have also have a hunch that the web activity bug fix for trusted UI may fix this bug. Krupa - Can you retest with the web activity patch included for trusted UI?

Comment 4

[krupa raj[:krupa]]

I can reproduce.

Note that at this point, the trustedUI is still overlapping the SMS app and after completing the purchase (by faking the SMS), I see the behavior described in comment 0

Comment 5

[krupa raj[:krupa]]

Is there some clear way to check if I have the activity patch in the unagi build I'm using?

Comment 6

[Jason Smith [:jsmith]]

(In reply to krupa raj 82[:krupa] from comment #5)
> Is there some clear way to check if I have the activity patch in the unagi
> build I'm using?

You would need to run that settings activity test I mentioned in a separate bug. I'll go grab a recent build and see what happens as well.

Comment 7

[Jason Smith [:jsmith]]

Okay...I just grabbed a recent nightly build and I still reproduce the bug with the settings web activity being fired. So it isn't just a SMS activity problem. Let me mark this a dependency on that bug.

I do know there was some nasty github problems that happened yesterday that may have delayed getting the patch included in the build. So maybe we need to wait a bit. I've put needsinfo on bug 829170 on Alberto to see if he knows.

Comment 8

[Jason Smith [:jsmith]]

I dug into this with a more recent build - I confirm Krupa's findings.

See bug 830036 for a followup. Let's try again after that's fixed.

Comment 9

[Jason Smith [:jsmith]]

Okay. Apparently the 1/15 build finally has the fix to that one web activity trusted UI issue. Can you retest now?

Comment 10

[krupa raj[:krupa]]

this works now.