829802 - Remove the pref svg.display-lists.painting.enabled

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Jesse Ruderman]

Per bug 808318 comment 7, the |false| value is no longer a supported configuration.

Comment 1

[Jonathan Watt [:jwatt]]

I think it's useful to wait one more release before removing this since, although disabling SVG display lists no longer works properly, it is still functional enough to help in quickly identifying SVG display list regressions.

We should also remove the hit-testing pref at the same time.

Comment 2

[Jesse Ruderman]

Do you feel comfortable removing it now?

Comment 3

[Robert Longson [:longsonr]]

Given that we're still getting regressions (bug 852101), I think we're better off still keeping it.

Comment 4

[Jonathan Watt [:jwatt]]

Just got another bug where this was useful, so no, still not yet.

Comment 5

[Alice0775 White]

regressions Bug 801949 ,Bug 852101, Bug 936950

Comment 6

[Jonathan Watt [:jwatt]]

We should possibly wontfix this based on bug 934411. If the non-display-list painting path can be taken from the root of an SVG document, then we need to keep that path working. (Unless we decide to prevent bug 934411's optimization for things that stop that painting path from working.)

Comment 7

[Jonathan Watt [:jwatt]]

I.e. we'd want to generalize nsDisplayOuterSVG to be usable for other SVG container elements.

Comment 9

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 829802 - Remove svg.display-lists prefs r=longsonr,jwatt,dholbert

See bug 1815115, this configuration doesn't work.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0f65338754cc
Remove svg.display-lists prefs r=longsonr

Comment 11

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/0f65338754cc