Closed
Bug 829843
Opened 12 years ago
Closed 12 years ago
"Name this tab group" in panorama overlaps the edit icon
Categories
(Firefox Graveyard :: Panorama, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 21
People
(Reporter: cers, Assigned: cers)
Details
Attachments
(1 file)
|
2.40 KB,
patch
|
ttaubert
:
review+
|
Details | Diff | Splinter Review |
The placeholder text in panorama for an unnamed tab group overlaps the edit icon on hover/focus. I suspect this is a regression caused by bug 737786, as the placeholder pseudo element doesn't seem to support padding.
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #702484 -
Flags: review?(ttaubert)
|
|
Assignee | |
Comment 2•12 years ago
|
||
Btw, as far as I can gather, this is why the ::-moz-placeholder pseudoelement doesn't currently support padding: http://mxr.mozilla.org/mozilla-central/source/layout/style/forms.css#131
|
||
Comment 3•12 years ago
|
||
Comment on attachment 702484 [details] [diff] [review]
Removes edit icon on focus/hover
Review of attachment 702484 [details] [diff] [review]:
-----------------------------------------------------------------
Thank you, good catch!
Attachment #702484 -
Flags: review?(ttaubert) → review+
|
|
||
Comment 4•12 years ago
|
||
Can you please prepare the patch for check-in? Add a summary, etc? Thanks!
|
||
Comment 5•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 21
|
||
Updated•9 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•