829948 - [toolbox] once toolbox is undocked, hide the the close button

Status: VERIFIED FIXED

(DevTools :: Framework, defect)

Comment 1

[Paul Rouget [:paul]]

I'm pretty sure that at some point, we supported that.

Comment 2

[Girish Sharma [:Optimizer]]

(In reply to Paul Rouget [:paul] from comment #1)
> I'm pretty sure that at some point, we supported that.

I don't think so. Looking at the history of Toolbox.jsm, I see these two lines:

let closeButton = this.doc.getElementById("toolbox-close");
closeButton.addEventListener("command", this.destroy, true);

unchanged, and nowhere else in the open() method we use closeButton variable.

Comment 4

[Paul Rouget [:paul]]

Attachment: v1

Comment 5

[Girish Sharma [:Optimizer]]

Comment on attachment 703943 [details] [diff] [review]
v1

Review of attachment 703943 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.

Comment 6

[Heather Arthur [:harth]]

Comment on attachment 703943 [details] [diff] [review]
v1

cool.

Comment 7

[Paul Rouget [:paul]]

Comment on attachment 703943 [details] [diff] [review]
v1

[Approval Request Comment]
Bug caused by (feature/regressing bug #): new feature (toolbox)
User impact if declined: extra close button in the UI
Testing completed (on m-c, etc.): locally
Risk to taking this patch (and alternatives if risky): very low
String or UUID changes made by this patch: no

Comment 8

[Paul Rouget [:paul]]

https://hg.mozilla.org/integration/fx-team/rev/785200131a17

Comment 9

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/785200131a17

Comment 10

[bhavana bajaj [:bajaj]]

Comment on attachment 703943 [details] [diff] [review]
v1

low risk uplift for a new feature in FF20. approving on aurora considering where we are in the release cycle.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/c00acb25f94f

Comment 12

[Simona Badau, Desktop QA]

Verified as fixed on the latest Nightly and Aurora - when the toolbox is undocked the "Close" button is hidden.

Verified on Windows 7, Ubuntu 12.10 and Mac OS X 10.8.2:
Mozilla/5.0 (Windows NT 6.1; rv:21.0) Gecko/20130210 Firefox/21.0 (20130210031150)
Mozilla/5.0 (Windows NT 6.1; rv:20.0) Gecko/20130210 Firefox/20.0 (20130210042017)

Mozilla/5.0 (X11; Linux i686; rv:21.0) Gecko/20130211 Firefox/21.0 (20130211031055)
Mozilla/5.0 (X11; Linux i686; rv:20.0) Gecko/20130210 Firefox/20.0 (20130210042017)

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:21.0) Gecko/20130211 Firefox/21.0 (20130211031055)
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:20.0) Gecko/20130211 Firefox/20.0 (20130211042016)