830020 - [B2G][Contacts]Address info from Facebook is showing hometown but not current living place

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[mlevin]

Attachment: FB shows home but not current living space

Description: Facebook contact only showing hometown but not current living place within Unagi contacts.
Suite Name: Contacts
Test Case #: N/A

Repro:
1) Update to Unagi build 201301120702022
2) Create a contact on Unagi
3) Link the contact to a Facebook contact which has Hometown and Current Living Place information both filled in.

Expected:
Example:
Facebook contact Matt Qanalyst is set up with 
Lives in Kirkland, Washington and
From Seattle, Washington
Unagi contact to show both of these.


Actual:
Unagi is only showing the following:
HOME
Kirkland, Wa


Repro frequency:
(1/1, on 2 separate devices)

Notes:
See Screenshot

Comment 1

[Alex Keybl [:akeybl]]

clee - how important is this from the product perspective? is this the design we want?

Comment 2

[Andrew Overholt [:overholt]]

Any UX input here, Ayman or Josh?

Comment 3

[Lukas Blakk [:lsblakk] use ?needinfo]

This is not a big enough issue to track, we'd take patch for approval if provided and requested by partners for uplifting.

Comment 4

[Peter Dolanjski [:pdol]]

Agree with the comments above, not a significant enough issue to track.  

Harald, can you ensure that Facebook is aware?

Comment 5

[Peter Dolanjski [:pdol]]

(In reply to Peter Dolanjski [:pdol] from comment #4)
> Harald, can you ensure that Facebook is aware?

Scratch that.  This isn't a Facebook issue.
Daniel, what do you want to do with this one?

Comment 6

[Daniel Coloma:dcoloma]

Jose Manuel, what is this issue about? Something we need to fix for 1.1?

Comment 7

[Jose Manuel Cantera]

I believe this should be fixed in koi. It is as simple as using current_address instead of current location in the query,

Comment 8

[Fernando Campo (:fcampo)]

Attachment: Link to PR - https://github.com/mozilla-b2g/gaia/pull/11482

Comment 9

[Francisco Jordano [:arcturus] [:francisco]]

Just leave a small comment on the code, looking pretty good.

Thanks!

Comment 10

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 788966 [details] [review]
Link to PR - https://github.com/mozilla-b2g/gaia/pull/11482

Travis complaining but not cause of this changes.

Tested the unit tests for this file and then the code in the phone and working fine.

Merging.

Thanks!

Comment 11

[Francisco Jordano [:arcturus] [:francisco]]

Landed:

https://github.com/mozilla-b2g/gaia/commit/4adf16422ddde49de5280270902ec059d20de540

Comment 12

[rafael.marquez]

Bug verified with:
Device: unagi
Branch: master 
Gecko: d445929
Gaia: 0395f26