830033 - If an update is found available with the update notification present, we need to notify the user of how many *new* updates are available now

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Jason Smith [:jsmith]]

Right now, if a user actively has a notification in their notification bar for updates being available, and then we find a new update from a manual or automatic sync, the update notification will change, but the user will not be notified that there was a change in the number of updates that typically shows up (the drop-down that appears saying "3 updates available" on the status bar). Minor nit - but it would be helpful to be clear to notify immediately if we find a brand new update in the list.

Comment 1

[Julien Wajsberg [:julienw]]

for me it's at least related, if not dupe, to Bug 824369

Comment 2

[Michał Budzyński (:michalbe)]

Attachment: patch

Comment 3

[Julien Wajsberg [:julienw]]

Comment on attachment 704866 [details]
patch

comments added on the pull request.

Please request a new review when you fixed this :)

Sorry for the long time before the review !

Comment 4

[Michał Budzyński (:michalbe)]

fixed, please review again.

Comment 5

[Julien Wajsberg [:julienw]]

Comment on attachment 704866 [details]
patch

r=me with the last nit addressed

Comment 6

[Michał Budzyński (:michalbe)]

https://github.com/mozilla-b2g/gaia/commit/080e6f71dbaed3b13ce6485d8957088d6af068b6

Comment 7

[Jason Smith [:jsmith]]

Should we try to get approval on this for v1.01?

Comment 8

[Julien Wajsberg [:julienw]]

For me this is definitely not a blocker, but this can lead to incomprehension and the patch is small.

However if this needs to land to 1.01 I'd like a superreview from etienne :-)

Comment 9

[Jason Smith [:jsmith]]

Whether it's a blocker or not doesn't really affect whether you ask for approval. Approval is asked for when you it's a low risk patch with some value to take into a branch. If it's low risk, we should ask for approval. But if additional review is needed first, I'd ask for an additional review then.

Comment 10

[Julien Wajsberg [:julienw]]

As a rule of thumb, I'll try to have an additional review for whatever will land in a branch. For now it's only a personal rule of thumb :)

Comment 11

[Julien Wajsberg [:julienw]]

Comment on attachment 704866 [details]
patch

etienne, wanna do a superreview on this ?

Comment 13

[Etienne Segonzac (:etienne)]

Comment on attachment 704866 [details]
patch

I'm flattered but I don't think that's what supperreviews are for :)

(That said the code looked good, minus the linting errors...)