830111 - [Settings] - arrange Phone lock screen

Status: RESOLVED DUPLICATE of bug 847552

(Firefox OS Graveyard :: Gaia::Settings, defect)

Comment 1

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: patch for Gaia repo

Comment 2

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Comment on attachment 701579 [details]
patch for Gaia repo

move to UX branch

Comment 3

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: patch for UX branch

Comment 4

[Fabien Cazenave [:kaze]]

Pavel: for the record, would you please attach two screenshots? (before/after your patch)

Comment 5

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: Before-After

Sure :)
when we habe error message I remove the Button ("Change") from the header because this cause problems

Comment 6

[Sam Joch [:samjoch]]

Landed in uxbranch: https://github.com/gordonbrander/gaia/commit/05c1026284406ee83fbfa504a32344c1c3e39b8f

Comment 7

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

I like the spacing at the top... 

having the error message appear then having to go back and then forward to retype the the passcodes again seems a bit ui unfriendly.

Comment 8

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

(In reply to Naoki Hirata :nhirata from comment #7)
I agree with Naoki, but it's better than before, because before this patch the error message appeared before the fields, and they moved it down under Keyboard and I need someone to help us with UX

Comment 9

[Patryk Adamczyk [:patryk] UX]

Can you merge this into the UX branch.

Comment 10

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

it is already landed to UX branch

Comment 11

[Sam Joch [:samjoch]]

https://github.com/mozilla-b2g/gaia/commit/25d9e53380db967d76223c5f1e1940ed907ed447

Comment 12

[Sam Joch [:samjoch]]

Comment on attachment 701586 [details]
patch for UX branch

Master commit hash is 1f919f1

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Not match UX spec.
User impact if declined: Polishing Passcode Panel
Testing completed: Yes
Risk to taking this patch (and alternatives if risky): Only polishing stuff.
String or UUID changes made by this patch:

Comment 13

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 701586 [details]
patch for UX branch

This comes from the UX branch process where QA has already checked that it works. a=me.

Comment 14

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Can't verify this bug due to bug 855107.

Comment 15

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Not sure bug 855107 is the outcome of this patch.  Can you please check Pavel?