I ask Kaze for feedback because the patch for this bug will contains extra DOM elements.
I guess I’m OK with that because it would get us rid of a few “position: fixed” rules, but I don’t think it’s a good idea to do this three days before the release, the risk-over-value ratio seems to high.
Josh, what do you think?
Every other app does this right. Settings should too :)
Josh, we’re not saying we shouldn’t do it: we’re wondering if it’s worth the risk at this point. Pavel, can you fix bug 815609 and this one in the UX branch?
Comment on attachment 701573 [details] patch for Gaia repo move to UX branch
Comment on attachment 701584 [details] patch for UX branch clearing the review as it’s moved to the UX branch
Landed in uxbranch: https://github.com/gordonbrander/gaia/commit/2321a9ab3feeb9a9b4217aa4d63f2a4af0b96903
Master build : 2013-03-26-07-02-04 "mozilla-central" revision="28b048ffb7a7" "integration/gaia-central" revision="44f6a17f24d4" "gecko.git"revision="a800f14ea7022a78966f7fe14a9b0d11c569b151" "gaia.git" revision="ace1eb32a313da1232bbdf9cff2581a4b036356d" Verified on master, not on v1 train.
Comment on attachment 701584 [details] patch for UX branch Is this ready to raise to approval? with user value and risk in the comments? Our goal is to wrap up all Yedo and VxD changes by April 5th.
Yes, I think so.
The master commit hash for this specific bug is 6bbe58edb16169c94dda6426ce77059d06d2a4fe.
Thanks, Pavel. Can you please raise to approval? - I tried but don't have the appropriate permissions. Sorry!
Comment on attachment 701584 [details] patch for UX branch clearing the r? as it’s been landed in the UX branch anyway.
Approval? still has not been raised on this. I would do it but I do not have permissions to do so. Please raise to approval so we can keep this moving for 1.1 and v1-train. Thank you!
Comment on attachment 701584 [details] patch for UX branch NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings. [Approval Request Comment] Bug caused by (feature/regressing bug #): - User impact if declined: see bug title Testing completed: yes, QA checked on master Risk to taking this patch (and alternatives if risky): very low, no logic change, small CSS change String or UUID changes made by this patch: none
visual design change requesting trackingb2g18 nom
(In reply to Fabien Cazenave [:kaze] from comment #22) > Merged on v1-train: > https://github.com/mozilla-b2g/gaia/commit/ > 1a1e9b44e75252746bf5ebe343ee06fd3c300612 This commit unexpectedly merged partial patch of bug 830644 and causes style class in html is inconsistent with css definition. (grep "sim-code-area" in both files). Furthermore, this patch also unexpectedly remove some DOM elements in settings/index.html and causes two regression bugs: bug 861215 and bug 861730. Sad. :'(