830404 - Regression: Delete All in the Download Manager not working

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Download Manager, defect)

Description

[Aaron Train [:aaronmt]]

E/GeckoConsole( 5959): [JavaScript Error: "NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIStringBundle.GetStringFromName]" {file: "chrome://browser/content/aboutDownloads.js" line: 441}]

Comment 1

[Aaron Train [:aaronmt]]

Wasn't fixed with that m-c back-out from the other day related to prefs

Comment 2

[Wesley Johnston (:wesj)]

I would guess this is from 827608

Comment 3

[Bill Gianopoulos [:WG9s]]

Regression window:

http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=0a6e5a67c4e8&tochange=8592c41069c2

which includes bug 827608

Comment 4

[Wesley Johnston (:wesj)]

Attachment: Patch

I didn't realize this strings was pulling double duty. This was not uplifted to Aurora, so there's no worry about the string changes there.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 705020 [details] [diff] [review]
Patch


>+downloadAction.deleteAll=Delete All
> # LOCALIZATION NOTE (downloadMessage.deleteAll):
> # Semi-colon list of plural forms. See:
> # http://developer.mozilla.org/en/docs/Localization_and_Plurals
> downloadMessage.deleteAll=Delete this download?;Delete #1 downloads?
> 

Can you move the string here? Add a blank line after it to separate from the downloadState strings

Comment 6

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/88869b74a28a

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/88869b74a28a