Last Comment Bug 830543 - No padding in the sidebar on pages without stylesheets.
: No padding in the sidebar on pages without stylesheets.
Status: RESOLVED FIXED
:
Product: Firefox
Classification: Client Software
Component: Developer Tools: Style Editor (show other bugs)
: Trunk
: x86 Mac OS X
: P3 normal (vote)
: Firefox 22
Assigned To: J. Ryan Stinnett [:jryans] (use ni?)
:
Mentors:
Depends on:
Blocks: 831709
  Show dependency treegraph
 
Reported: 2013-01-14 15:47 PST by Anton Kovalyov (:anton)
Modified: 2013-03-12 01:39 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Style Editor on a page without stylesheets. (620.00 KB, image/png)
2013-01-14 15:47 PST, Anton Kovalyov (:anton)
no flags Details
Add padding to style editor nav when no stylesheets present (1.43 KB, patch)
2013-02-18 15:45 PST, J. Ryan Stinnett [:jryans] (use ni?)
no flags Details | Diff | Splinter Review
Screenshot: After padding adjustment (27.94 KB, image/png)
2013-02-18 17:40 PST, J. Ryan Stinnett [:jryans] (use ni?)
no flags Details
Add padding to style editor nav when no stylesheets present v2 (2.43 KB, patch)
2013-02-22 13:17 PST, J. Ryan Stinnett [:jryans] (use ni?)
paul: review+
Details | Diff | Splinter Review
Patch v3 (2.38 KB, patch)
2013-03-01 00:41 PST, J. Ryan Stinnett [:jryans] (use ni?)
paul: review+
Details | Diff | Splinter Review

Description Anton Kovalyov (:anton) 2013-01-14 15:47:18 PST
Created attachment 702052 [details]
Style Editor on a page without stylesheets.

On pages without any stylesheets the Style Editor sidebar gets the width of its longest string ("Perhaps you'd like to append a new style sheet?") without any padding from its sides. It looks odd.
Comment 1 J. Ryan Stinnett [:jryans] (use ni?) 2013-02-18 15:45:42 PST
Created attachment 715270 [details] [diff] [review]
Add padding to style editor nav when no stylesheets present

I've added a small amount of padding around the "no files" text to resolve this issue.
Comment 2 J. Ryan Stinnett [:jryans] (use ni?) 2013-02-18 17:40:29 PST
Created attachment 715295 [details]
Screenshot: After padding adjustment
Comment 3 Paul Rouget [:paul] 2013-02-22 03:49:12 PST
Comment on attachment 715270 [details] [diff] [review]
Add padding to style editor nav when no stylesheets present

Thanks for looking at this.

These changes need to happen in the theme/ directory:

> browser/themes/gnomestripe/devtools/styleeditor.css
> browser/themes/winstripe/devtools/styleeditor.css
> browser/themes/pinstripe/devtools/styleeditor.css

For the AUTHOR changes, this will happen afterwards (go to about:credits, and see the latest paragraph).
Comment 4 J. Ryan Stinnett [:jryans] (use ni?) 2013-02-22 13:15:36 PST
(In reply to Paul Rouget [:paul] from comment #3)
> Comment on attachment 715270 [details] [diff] [review]
> Add padding to style editor nav when no stylesheets present
> 
> Thanks for looking at this.
> 
> These changes need to happen in the theme/ directory:

Ah, thanks, didn't realize the split between content vs. theme CSS.
Comment 5 J. Ryan Stinnett [:jryans] (use ni?) 2013-02-22 13:17:16 PST
Created attachment 717287 [details] [diff] [review]
Add padding to style editor nav when no stylesheets present v2
Comment 6 Paul Rouget [:paul] 2013-02-27 17:01:26 PST
Comment on attachment 717287 [details] [diff] [review]
Add padding to style editor nav when no stylesheets present v2

Thank you!
Comment 7 Panos Astithas [:past] 2013-02-28 23:17:52 PST
The recent theme folder reorganization bitrotted this. Needs rebasing.
Comment 8 J. Ryan Stinnett [:jryans] (use ni?) 2013-03-01 00:41:30 PST
Created attachment 719853 [details] [diff] [review]
Patch v3

Updated patch for the themes reorg.
Comment 9 Panos Astithas [:past] 2013-03-11 15:56:20 PDT
https://hg.mozilla.org/integration/fx-team/rev/62067564d539
Comment 10 Tim Taubert [:ttaubert] 2013-03-12 01:39:38 PDT
https://hg.mozilla.org/mozilla-central/rev/62067564d539

Note You need to log in before you can comment on or make changes to this bug.