No padding in the sidebar on pages without stylesheets.

RESOLVED FIXED in Firefox 22

Status

()

Firefox
Developer Tools: Style Editor
P3
normal
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: anton, Assigned: jryans)

Tracking

Trunk
Firefox 22
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 3 obsolete attachments)

(Reporter)

Description

5 years ago
Created attachment 702052 [details]
Style Editor on a page without stylesheets.

On pages without any stylesheets the Style Editor sidebar gets the width of its longest string ("Perhaps you'd like to append a new style sheet?") without any padding from its sides. It looks odd.

Updated

5 years ago
Blocks: 831709
(Assignee)

Comment 1

5 years ago
Created attachment 715270 [details] [diff] [review]
Add padding to style editor nav when no stylesheets present

I've added a small amount of padding around the "no files" text to resolve this issue.
Attachment #715270 - Flags: review?
(Assignee)

Updated

5 years ago
Attachment #715270 - Flags: review? → review?(paul)
(Assignee)

Comment 2

5 years ago
Created attachment 715295 [details]
Screenshot: After padding adjustment

Comment 3

5 years ago
Comment on attachment 715270 [details] [diff] [review]
Add padding to style editor nav when no stylesheets present

Thanks for looking at this.

These changes need to happen in the theme/ directory:

> browser/themes/gnomestripe/devtools/styleeditor.css
> browser/themes/winstripe/devtools/styleeditor.css
> browser/themes/pinstripe/devtools/styleeditor.css

For the AUTHOR changes, this will happen afterwards (go to about:credits, and see the latest paragraph).
Attachment #715270 - Flags: review?(paul)
(Assignee)

Comment 4

5 years ago
(In reply to Paul Rouget [:paul] from comment #3)
> Comment on attachment 715270 [details] [diff] [review]
> Add padding to style editor nav when no stylesheets present
> 
> Thanks for looking at this.
> 
> These changes need to happen in the theme/ directory:

Ah, thanks, didn't realize the split between content vs. theme CSS.
(Assignee)

Comment 5

5 years ago
Created attachment 717287 [details] [diff] [review]
Add padding to style editor nav when no stylesheets present v2
Attachment #717287 - Flags: review?
(Assignee)

Updated

5 years ago
Attachment #717287 - Flags: review? → review?(paul)
(Assignee)

Updated

5 years ago
Attachment #715270 - Attachment is obsolete: true

Comment 6

5 years ago
Comment on attachment 717287 [details] [diff] [review]
Add padding to style editor nav when no stylesheets present v2

Thank you!
Attachment #717287 - Flags: review?(paul) → review+

Updated

5 years ago
Whiteboard: [land-in-fx-team]
The recent theme folder reorganization bitrotted this. Needs rebasing.
Whiteboard: [land-in-fx-team]
(Assignee)

Comment 8

5 years ago
Created attachment 719853 [details] [diff] [review]
Patch v3

Updated patch for the themes reorg.
Attachment #702052 - Attachment is obsolete: true
Attachment #717287 - Attachment is obsolete: true
Attachment #719853 - Flags: review?(paul)
(Assignee)

Updated

5 years ago
Assignee: nobody → jryans
Status: NEW → ASSIGNED

Updated

4 years ago
Attachment #719853 - Flags: review?(paul) → review+

Updated

4 years ago
Whiteboard: [land-in-fx-team]
https://hg.mozilla.org/integration/fx-team/rev/62067564d539
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/62067564d539
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 22
You need to log in before you can comment on or make changes to this bug.