830543 - No padding in the sidebar on pages without stylesheets.

Status: RESOLVED FIXED

(DevTools :: Style Editor, defect, P3)

Description

[Anton Kovalyov (:anton)]

Attachment: Style Editor on a page without stylesheets.

On pages without any stylesheets the Style Editor sidebar gets the width of its longest string ("Perhaps you'd like to append a new style sheet?") without any padding from its sides. It looks odd.

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: Add padding to style editor nav when no stylesheets present

I've added a small amount of padding around the "no files" text to resolve this issue.

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: Screenshot: After padding adjustment

Comment 3

[Paul Rouget [:paul]]

Comment on attachment 715270 [details] [diff] [review]
Add padding to style editor nav when no stylesheets present

Thanks for looking at this.

These changes need to happen in the theme/ directory:

> browser/themes/gnomestripe/devtools/styleeditor.css
> browser/themes/winstripe/devtools/styleeditor.css
> browser/themes/pinstripe/devtools/styleeditor.css

For the AUTHOR changes, this will happen afterwards (go to about:credits, and see the latest paragraph).

Comment 4

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

(In reply to Paul Rouget [:paul] from comment #3)
> Comment on attachment 715270 [details] [diff] [review]
> Add padding to style editor nav when no stylesheets present
> 
> Thanks for looking at this.
> 
> These changes need to happen in the theme/ directory:

Ah, thanks, didn't realize the split between content vs. theme CSS.

Comment 5

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: Add padding to style editor nav when no stylesheets present v2

Comment 6

[Paul Rouget [:paul]]

Comment on attachment 717287 [details] [diff] [review]
Add padding to style editor nav when no stylesheets present v2

Thank you!

Comment 7

[Panos Astithas (he/him) [:past] (please ni?)]

The recent theme folder reorganization bitrotted this. Needs rebasing.

Comment 8

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: Patch v3

Updated patch for the themes reorg.

Comment 9

[Panos Astithas (he/him) [:past] (please ni?)]

https://hg.mozilla.org/integration/fx-team/rev/62067564d539

Comment 10

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/62067564d539