830565 - Add isPrivateBrowsing property to Tab class

Status: RESOLVED WONTFIX

(Add-on SDK Graveyard :: General, defect)

Comment 1

[Erik Vold [:erikvold] (please needinfo? me)]

Irakli you should take a look at this proposed API change.

Comment 2

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Erik, I do believe you suggested somewhere alternative of having `isPrivateBrowsing(thingy)` don't remember where, or could be that I misunderstood.

Either way I think that would be a better option, since `thingy` can be window or tab or whatever else may come up in a future (panel ?).

What do you think ?

Comment 3

[Erik Vold [:erikvold] (please needinfo? me)]

I do like that better, that is bug 828746.  The problem is that in bug 777813 I added a `isPrivateBrowsing` getter to our Window class.

Does it sound alright to deprecate the `isPrivateBrowsing` property in bug 828746 ?

Comment 4

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

It's little lame to do this now, but I think it's probably for the best. So I'd say yes.

Comment 5

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Also I thing `require("sdk/private-browsing").isPrivate(aObject)` suggested by you is better name than `isPrivateBrowsing`. So let's stick to it instead.

Comment 6

[Erik Vold [:erikvold] (please needinfo? me)]

Alright let's close this bug then.